Require operator.admin for /dreaming persistence#63818
Conversation
Greptile SummaryThis PR adds an Confidence Score: 5/5Safe to merge — the guard is correct, well-tested, and non-gateway behavior is preserved. All findings are P2 or lower. The requiresAdminToMutateDreaming logic correctly handles the three cases (undefined = non-gateway allow, empty array = block, admin scope = allow). Tests cover all relevant gateway paths. No regressions to existing non-gateway behavior. No files require special attention.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c355d35ea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
@greptile review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Summary
operator.adminbefore/dreaming on|offpersists config for scoped gateway callers/dreaming statusand non-gateway command behavior unchangedChanges
memory-coredreaming command before writing configValidation
pnpm test extensions/memory-core/src/dreaming-command.test.tspnpm checkpnpm buildNotes
claude -p "/review"step was attempted but blocked in this environment because the tool requested interactive approval to inspect PR state