Skip to content

fix(onboard): skip Homebrew prompt on FreeBSD#68910

Closed
Eruditi wants to merge 1 commit intoopenclaw:mainfrom
Eruditi:fix/freebsd-homebrew-prompt
Closed

fix(onboard): skip Homebrew prompt on FreeBSD#68910
Eruditi wants to merge 1 commit intoopenclaw:mainfrom
Eruditi:fix/freebsd-homebrew-prompt

Conversation

@Eruditi
Copy link
Copy Markdown

@Eruditi Eruditi commented Apr 19, 2026

FreeBSD uses pkg/ports, not Homebrew. The onboard skills wizard should not recommend Homebrew installation on FreeBSD systems.

Closes #68893

@openclaw-barnacle openclaw-barnacle Bot added commands Command implementations size: XS labels Apr 19, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 19, 2026

Greptile Summary

Adds process.platform !== "freebsd" to the existing platform guard that suppresses the Homebrew installation prompt on Windows, fixing issue #68893 where FreeBSD users were incorrectly prompted about Homebrew. The change is minimal, correct, and well-scoped to the reported problem.

Confidence Score: 5/5

Safe to merge — single-line targeted fix with no functional risk.

The only finding is a P2 style suggestion about future-proofing with an allowlist approach; it doesn't affect correctness of the current fix.

No files require special attention.

Prompt To Fix All With AI
This is a comment left during a code review.
Path: src/commands/onboard-skills.ts
Line: 111-114

Comment:
**Other non-Homebrew platforms not covered**

`openbsd`, `netbsd`, and `sunos` also don't support Homebrew natively. If this guard grows to include more platforms, consider inverting the logic to an allowlist of platforms where Homebrew is actually supported (e.g. `darwin` and `linux`) rather than a blocklist:

```
const needsBrewPrompt =
  (process.platform === "darwin" || process.platform === "linux") &&
  selectedSkills.some((skill) => skill.install.some((option) => option.kind === "brew")) &&
  !(await detectBinary("brew"));
```

This is a non-blocking suggestion — the current fix is correct for the reported issue.

How can I resolve this? If you propose a fix, please make it concise.

Reviews (1): Last reviewed commit: "fix(onboard): skip Homebrew prompt on Fr..." | Re-trigger Greptile

Comment on lines 111 to 114
const needsBrewPrompt =
process.platform !== "win32" &&
process.platform !== "win32" && process.platform !== "freebsd" &&
selectedSkills.some((skill) => skill.install.some((option) => option.kind === "brew")) &&
!(await detectBinary("brew"));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Other non-Homebrew platforms not covered

openbsd, netbsd, and sunos also don't support Homebrew natively. If this guard grows to include more platforms, consider inverting the logic to an allowlist of platforms where Homebrew is actually supported (e.g. darwin and linux) rather than a blocklist:

const needsBrewPrompt =
  (process.platform === "darwin" || process.platform === "linux") &&
  selectedSkills.some((skill) => skill.install.some((option) => option.kind === "brew")) &&
  !(await detectBinary("brew"));

This is a non-blocking suggestion — the current fix is correct for the reported issue.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/commands/onboard-skills.ts
Line: 111-114

Comment:
**Other non-Homebrew platforms not covered**

`openbsd`, `netbsd`, and `sunos` also don't support Homebrew natively. If this guard grows to include more platforms, consider inverting the logic to an allowlist of platforms where Homebrew is actually supported (e.g. `darwin` and `linux`) rather than a blocklist:

```
const needsBrewPrompt =
  (process.platform === "darwin" || process.platform === "linux") &&
  selectedSkills.some((skill) => skill.install.some((option) => option.kind === "brew")) &&
  !(await detectBinary("brew"));
```

This is a non-blocking suggestion — the current fix is correct for the reported issue.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@Eruditi Eruditi closed this Apr 19, 2026
@Eruditi Eruditi deleted the fix/freebsd-homebrew-prompt branch April 19, 2026 13:16
@prtags
Copy link
Copy Markdown

prtags Bot commented Apr 21, 2026

Related work from PRtags group actual-grouse-o3j8

Title: Open PR duplicate: onboard Homebrew prompt on unsupported platforms

Number Title
#68894 fix(onboard): don't suggest Homebrew on non-macOS/Linux platforms (closes #68893)
#68910* fix(onboard): skip Homebrew prompt on FreeBSD
#68941 fix: skip Homebrew prompt on FreeBSD and other non-Linux/macOS platforms
#68943 fix: skip Homebrew prompt on FreeBSD
#69002 Fix: skip Homebrew prompt on platforms brew doesn't support (Resolves #68893)
#69545 fix(onboard): skip Homebrew recommendation on FreeBSD

* This PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands Command implementations size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: OpenClaw talks about Homebrew on FreeBSD

1 participant