fix(onboard): skip Homebrew prompt on FreeBSD#68910
fix(onboard): skip Homebrew prompt on FreeBSD#68910Eruditi wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Greptile SummaryAdds Confidence Score: 5/5Safe to merge — single-line targeted fix with no functional risk. The only finding is a P2 style suggestion about future-proofing with an allowlist approach; it doesn't affect correctness of the current fix. No files require special attention. Prompt To Fix All With AIThis is a comment left during a code review.
Path: src/commands/onboard-skills.ts
Line: 111-114
Comment:
**Other non-Homebrew platforms not covered**
`openbsd`, `netbsd`, and `sunos` also don't support Homebrew natively. If this guard grows to include more platforms, consider inverting the logic to an allowlist of platforms where Homebrew is actually supported (e.g. `darwin` and `linux`) rather than a blocklist:
```
const needsBrewPrompt =
(process.platform === "darwin" || process.platform === "linux") &&
selectedSkills.some((skill) => skill.install.some((option) => option.kind === "brew")) &&
!(await detectBinary("brew"));
```
This is a non-blocking suggestion — the current fix is correct for the reported issue.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(onboard): skip Homebrew prompt on Fr..." | Re-trigger Greptile |
| const needsBrewPrompt = | ||
| process.platform !== "win32" && | ||
| process.platform !== "win32" && process.platform !== "freebsd" && | ||
| selectedSkills.some((skill) => skill.install.some((option) => option.kind === "brew")) && | ||
| !(await detectBinary("brew")); |
There was a problem hiding this comment.
Other non-Homebrew platforms not covered
openbsd, netbsd, and sunos also don't support Homebrew natively. If this guard grows to include more platforms, consider inverting the logic to an allowlist of platforms where Homebrew is actually supported (e.g. darwin and linux) rather than a blocklist:
const needsBrewPrompt =
(process.platform === "darwin" || process.platform === "linux") &&
selectedSkills.some((skill) => skill.install.some((option) => option.kind === "brew")) &&
!(await detectBinary("brew"));
This is a non-blocking suggestion — the current fix is correct for the reported issue.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/commands/onboard-skills.ts
Line: 111-114
Comment:
**Other non-Homebrew platforms not covered**
`openbsd`, `netbsd`, and `sunos` also don't support Homebrew natively. If this guard grows to include more platforms, consider inverting the logic to an allowlist of platforms where Homebrew is actually supported (e.g. `darwin` and `linux`) rather than a blocklist:
```
const needsBrewPrompt =
(process.platform === "darwin" || process.platform === "linux") &&
selectedSkills.some((skill) => skill.install.some((option) => option.kind === "brew")) &&
!(await detectBinary("brew"));
```
This is a non-blocking suggestion — the current fix is correct for the reported issue.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Related work from PRtags group Title: Open PR duplicate: onboard Homebrew prompt on unsupported platforms
|
FreeBSD uses pkg/ports, not Homebrew. The onboard skills wizard should not recommend Homebrew installation on FreeBSD systems.
Closes #68893