Skip to content

fix(gateway): preserve cron delivery validation semantics#69040

Merged
obviyus merged 3 commits intoopenclaw:mainfrom
obviyus:fix/cron-delivery-validation-followups
Apr 19, 2026
Merged

fix(gateway): preserve cron delivery validation semantics#69040
obviyus merged 3 commits intoopenclaw:mainfrom
obviyus:fix/cron-delivery-validation-followups

Conversation

@obviyus
Copy link
Copy Markdown
Contributor

@obviyus obviyus commented Apr 19, 2026

Keeps cron delivery validation aligned with actual runtime behavior.

Fixes the two follow-ups from #69015: disabled channels no longer create false ambiguity, and delivery patch validation now uses the live cron service default agent.

@openclaw-barnacle openclaw-barnacle bot added the gateway Gateway runtime label Apr 19, 2026
@openclaw-barnacle openclaw-barnacle bot added size: S maintainer Maintainer-authored PR labels Apr 19, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 19, 2026

Greptile Summary

This PR fixes two validation alignment issues in cron delivery: listConfiguredAnnounceChannelIds now filters out channels where enabled: false so they don't count toward the "multiple configured channels" ambiguity threshold, and assertValidCronUpdateDelivery now forwards the live defaultAgentId from context.cron.getDefaultAgentId() into applyJobPatch so the patch simulation matches actual runtime behavior. Both fixes are backed by new integration tests.

Confidence Score: 5/5

Safe to merge — both fixes are narrow, well-reasoned, and covered by new integration tests.

No P0 or P1 findings. The disabled-channel filter (enabled !== false) correctly treats channels without an explicit enabled field as enabled, the TOCTOU gap between validation and update is an acceptable design trade-off, and the three new tests directly exercise both bug scenarios.

No files require special attention.

Reviews (1): Last reviewed commit: "docs(changelog): note cron delivery vali..." | Re-trigger Greptile

@obviyus obviyus self-assigned this Apr 19, 2026
@obviyus obviyus merged commit c206702 into openclaw:main Apr 19, 2026
48 checks passed
@obviyus
Copy link
Copy Markdown
Contributor Author

obviyus commented Apr 19, 2026

Landed on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gateway Gateway runtime maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant