fix(codex): remove spurious migration warnings#81966
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. from source: current main's Codex migration planner emits the reported plan-level warnings for normal migratable plugin and archive state, and the PR body provides a real dry-run command showing zero targeted warning matches after the patch. Real behavior proof Next step before merge Security Review detailsBest possible solution: Land the narrow warning-removal change after required checks finish and protected-label maintainer handling is complete, while keeping real conflict, discovery, subscription, and provider warnings serialized. Do we have a high-confidence way to reproduce the issue? Yes, from source: current main's Codex migration planner emits the reported plan-level warnings for normal migratable plugin and archive state, and the PR body provides a real dry-run command showing zero targeted warning matches after the patch. Is this the best way to solve the issue? Yes; removing the warning emissions at the provider source and deleting the now-unused CLI filter is the narrow maintainable fix, and the diff leaves provider warning serialization covered by tests. Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 9f99464119a6. |
f3a9720 to
a1bc388
Compare
Summary
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Real behavior proof (required for external PRs)
openclaw migrate codex --dry-run --jsoncommand against local Codex migration state.pnpm openclaw migrate codex --dry-run --json > /tmp/openclaw-codex-migrate-dry-run.jsonfollowed by a local JSON parse that checked the four removed warning strings.pnpm check/full suite was not run locally because this is a Codex worktree and repo policy routes broad proof through Testbox/Crabbox rather than local pnpm gates.Root Cause (if applicable)
Regression Test Plan (if applicable)
extensions/codex/src/migration/provider.test.ts;src/commands/migrate.test.ts.plans app-backed plugins without source app/list by default; updated JSON warning output coverage.User-visible / Behavior Changes
Codex migration output no longer shows the removed spurious warning messages. Migration item details and actual blocking warnings remain available.
Diagram (if applicable)
N/A
Security Impact (required)
Yes, explain risk + mitigation: N/ARepro + Verification
Environment
Steps
pnpm openclaw migrate codex --dry-run --json > /tmp/openclaw-codex-migrate-dry-run.jsonand parse the JSON for removed warning strings.node scripts/run-vitest.mjs extensions/codex/src/migration/provider.test.ts src/commands/migrate.test.ts.pnpm exec oxfmt --check --threads=1 extensions/codex/src/migration/plan.ts extensions/codex/src/migration/provider.test.ts src/commands/migrate.ts src/commands/migrate.test.ts.git diff --check.Expected
Actual
targetedWarningMatches=0.