fix: deliver generated media as structured attachments#82084
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: deliver generated media as structured attachments This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
767ea92 to
04d253a
Compare
Contributor
Author
|
Landed via rebase onto main.
Merged with maintainer proof override because GitHub Actions stayed queued after local proof. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MEDIA:text.messageavailable for message-tool-only Codex completions across allowlists, tool profiles, and replay/tool construction.attachmentsand align telemetry aliases with real delivery.Verification
OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/agents/pi-embedded-runner/run/attempt-tool-construction-plan.test.ts extensions/codex/src/app-server/run-attempt.test.ts src/agents/pi-embedded-subscribe.tools.media.test.ts src/infra/outbound/message-action-runner.media.test.tsOPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/infra/outbound/message-action-runner.media.test.ts extensions/codex/src/app-server/dynamic-tools.test.ts src/agents/pi-embedded-subscribe.handlers.tools.test.ts src/agents/subagent-announce-delivery.test.tsOPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/agents/openclaw-tools.update-plan.test.ts src/agents/pi-tools.create-openclaw-coding-tools.test.ts src/agents/pi-embedded-runner/run/attempt-tool-construction-plan.test.tsgit diff --checkcodex review --base origin/main(clean after fixups)Behavior addressed: generated media completion handoffs now carry message-tool-compatible structured attachments and require actual media delivery.
Real environment tested: local focused Vitest suites plus Codex autoreview.
Exact steps or command run after this patch: focused commands listed above.
Evidence after fix: tests cover generated attachment extraction, message-tool alias telemetry, real send-path
attachments, forced message through explicit allowlists including empty allowlists, and completion delivery failure on text-only media replies.Observed result after fix: Codex autoreview reported no blocking correctness issues.
What was not tested: live Hetzner/Discord/ClawSweeper end-to-end media post.