refactor: record dropped channel history in turn kernel#82131
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: refactor: record dropped channel history in turn kernel This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Real behavior proof
Behavior addressed: dropped/no-mention message history recording is now driven by the core channel turn kernel instead of each message plugin calling the history recorder directly.
Real environment tested: local OpenClaw source checkout on macOS plus Testbox remote changed gate for the branch head.
Exact steps or command run after this patch:
OPENCLAW_TESTBOX_REMOTE_RUN=1 OPENCLAW_VITEST_MAX_WORKERS=1 pnpm check:changedafter focused local kernel, Discord, Slack, core tsgo, and extension tsgo proof.Evidence after fix: terminal output from the real source checkout and Testbox changed gate:
Observed result after fix: copied live output showed the changed gate completed successfully on the branch head; Discord and Slack skipped inbound messages still flow into history recording, while the record-on-drop decision now runs through the shared turn kernel.
What was not tested: live Discord or Slack webhook traffic; this PR is the core refactor on top of the already landed image-history behavior PR.