fix(openai): allow available Codex OAuth models#83318
Merged
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(openai): allow available Codex OAuth models This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
8da9d12 to
b3152eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #83303
Verification
node scripts/run-vitest.mjs src/config/config.model-ref-validation.test.ts src/agents/model-catalog.test.ts src/agents/pi-embedded-runner/model.test.tsgit diff --checkpnpm docs:listReal behavior proof
Behavior addressed: Existing configs using available openai-codex GPT-5.1/GPT-5.2/GPT-5.3 refs no longer fail config validation solely because of stale manifest suppressions; removed Spark aliases remain rejected.
Real environment tested: Local source checkout on macOS, targeted Vitest via repo node wrapper.
Exact steps or command run after this patch:
node scripts/run-vitest.mjs src/config/config.model-ref-validation.test.ts src/agents/model-catalog.test.ts src/agents/pi-embedded-runner/model.test.tsEvidence after fix: Config validation accepts openai-codex/gpt-5.2-codex and openai-codex/gpt-5.3-codex fallbacks; catalog/runtime tests keep available Codex rows and resolve openai-codex/gpt-5.3-codex.
Observed result after fix: 5 test files and 227 tests passed.
What was not tested: Live ChatGPT/Codex OAuth request to gpt-5.3-codex and full Docker setup path.