Skip to content

fix(gateway): dedupe probe warnings by gateway identity#85791

Merged
giodl73-repo merged 8 commits into
openclaw:mainfrom
giodl73-repo:fix-69135-gateway-probe-identity
Jun 5, 2026
Merged

fix(gateway): dedupe probe warnings by gateway identity#85791
giodl73-repo merged 8 commits into
openclaw:mainfrom
giodl73-repo:fix-69135-gateway-probe-identity

Conversation

@giodl73-repo
Copy link
Copy Markdown
Contributor

@giodl73-repo giodl73-repo commented May 23, 2026

Summary

  • Rebase the gateway identity warning fix onto current main.
  • Preserve the conservative same-host gateway warning behavior while deduping probe warnings by gateway identity.
  • Restore inline-code formatting around changed gateway CLI flags, warning codes, and operator.read docs text per review feedback.
  • No config, CLI, plugin API, or public surface changes.

Validation

  • OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/infra/system-presence.test.ts src/infra/system-presence.version.test.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=dot (3 shards, 22 tests)
  • node_modules/oxfmt/bin/oxfmt --check --threads=1 src/infra/system-presence.ts docs/cli/gateway.md docs/gateway/index.md docs/gateway/multiple-gateways.md docs/gateway/troubleshooting.md src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts
  • node_modules/oxlint/bin/oxlint --tsconfig config/tsconfig/oxlint.core.json src/infra/system-presence.ts src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts
  • git diff --check origin/main...HEAD && git diff --check

Current Head

  • Rebased on main at 69df4c9136173b7387d4cf79ccd9121c93d49932.
  • Signed head: 13e3c00f56.

@openclaw-barnacle openclaw-barnacle Bot added commands Command implementations size: M maintainer Maintainer-authored PR labels May 23, 2026
@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented May 23, 2026

Codex review: needs maintainer review before merge. Reviewed June 4, 2026, 3:23 PM ET / 19:23 UTC.

Summary
The PR changes gateway probe/status warnings to dedupe reachable probe targets by gateway self identity, adds a per-process self identity field, and updates gateway warning docs/tests.

PR surface: Source +55, Tests +216, Docs +2. Total +273 across 9 files.

Reproducibility: yes. Current main builds both SSH tunnel and configured remote targets and warns on reachable.length > 1; the linked report and contributor live proof cover the same single-gateway, multiple-transport path.

Review metrics: none identified.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Risk before merge

  • [P1] The PR has the protected maintainer label, so cleanup should not auto-close or auto-land it without explicit maintainer handling.

Maintainer options:

  1. Decide the mitigation before merge
    Land this focused identity-based warning fix after maintainer review, then close the linked false-positive report once the PR is merged.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • No automated repair is needed; the remaining action is maintainer review/landing because the PR is protected by the maintainer label.

Security
Cleared: The diff only touches gateway diagnostics code, docs, and tests; it does not change secrets, workflows, dependencies, package metadata, or code-download paths.

Review details

Best possible solution:

Land this focused identity-based warning fix after maintainer review, then close the linked false-positive report once the PR is merged.

Do we have a high-confidence way to reproduce the issue?

Yes. Current main builds both SSH tunnel and configured remote targets and warns on reachable.length > 1; the linked report and contributor live proof cover the same single-gateway, multiple-transport path.

Is this the best way to solve the issue?

Yes. Dedupe at the warning/output layer keeps the useful direct-path probe intact, while skipping redundant configured targets would reduce diagnostics coverage.

AGENTS.md: found and applied where relevant.

Codex review notes: model gpt-5.5, reasoning high; reviewed against ab0a633ab98b.

Label changes

Label changes:

  • add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • remove rating: 🐚 platinum hermit: Current PR rating is rating: 🦞 diamond lobster, so this older rating label is no longer current.

Label justifications:

  • P2: This is a normal-priority gateway diagnostics bug fix with limited blast radius and focused tests/proof.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The contributor provided after-fix live CLI proof using a temporary gateway plus sshd in a Linux network namespace, showing no multiple_gateways warning for two transports to the same gateway identity.
  • proof: sufficient: Contributor real behavior proof is sufficient. The contributor provided after-fix live CLI proof using a temporary gateway plus sshd in a Linux network namespace, showing no multiple_gateways warning for two transports to the same gateway identity.
Evidence reviewed

PR surface:

Source +55, Tests +216, Docs +2. Total +273 across 9 files.

View PR surface stats
Area Files Added Removed Net
Source 3 60 5 +55
Tests 2 216 0 +216
Docs 4 8 6 +2
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 9 284 11 +273

What I checked:

Likely related people:

  • Peter Steinberger: Blame and history tie the current warning block, gateway status output, docs warning mirrors, and gateway self-presence helper to recent commits by this author. (role: recent area contributor; confidence: high; commits: ddc832ead169, 852d3a742c6c, 3effffb4911b; files: src/commands/gateway-status/output.ts, src/commands/gateway-presence.ts, docs/cli/gateway.md)
  • Vincent Koc: History shows related gateway probe/presence work, including the presence-only probe mode used by gateway status diagnostics. (role: adjacent gateway/probe contributor; confidence: medium; commits: d8e138c74337, 2e08f0f4221f; files: src/gateway/probe.ts, src/commands/gateway-status/probe-run.ts, src/infra/system-presence.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal backlog priority with limited blast radius. labels May 23, 2026
@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented May 23, 2026

ClawSweeper PR egg

✨ Hatched: 💎 rare Moonlit Branchling

Hatch command

Comment @clawsweeper hatch when this PR is hatchable.

Hatchability rules:

  • Merged PRs are hatchable.
  • Open PRs are hatchable when they are status: 👀 ready for maintainer look, status: 🚀 automerge armed, or labeled clawsweeper:automerge.
  • Closed unmerged PRs are hatchable only when one of those hatchable labels is still present in the durable record.

Rarity: 💎 rare.
Trait: sparkles near resolved comments.
Image traits: location CI tidepool; accessory release bell; palette plum, gold, and soft gray; mood curious; pose waving from a small platform; shell paper lantern shell; lighting cool dashboard glow; background subtle branch markers.
Share on X: post this hatch
Copy: My PR egg hatched a 💎 rare Moonlit Branchling in ClawSweeper.

What is this egg doing here?
  • Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
  • The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
  • Hatchability usually comes from sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness. A merged PR is already final, so merge makes the egg hatchable independently.
  • The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
  • Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

@galiniliev galiniliev self-assigned this May 23, 2026
Copy link
Copy Markdown
Contributor

@galiniliev galiniliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a focused fix for #69135: gateway probe can probe an SSH tunnel URL and a configured remote URL that both reach the same gateway, and the patch changes multiple_gateways from a raw reachable-target count to a conservative self-identity + logical-port check. The source-level behavior and the focused tests line up with the reported bug.

Findings:

  • [P2] Please align the gateway docs with the new warning semantics. The code now suppresses multiple_gateways when reachable transports share a gateway identity, but the public gateway docs still describe the warning as "more than one target was reachable" / "more than one target answered" (docs/cli/gateway.md:337, docs/cli/gateway.md:382, docs/gateway/troubleshooting.md:576). After this patch that is no longer true: two targets can answer and correctly produce no warning if they identify as the same gateway on the same logical port. Please update those docs to describe the warning as distinct or identity-ambiguous reachable gateways, and mention that SSH tunnel + configured remote can be one gateway with multiple transports.

  • [P2] Please add real behavior evidence before merge, or explicitly document why maintainer acceptance is unit-only here. The implementation has good fixture coverage, and I verified the focused tests locally, but the PR body still says a live SSH tunnel plus direct WebSocket probe was not tested. For this bug, the user-visible claim is specifically the openclaw gateway probe SSH/direct remote flow, so a redacted terminal transcript, screenshot, or logs showing the post-patch command output would close the proof gap.

Proof I ran:

node scripts/run-vitest.mjs src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=verbose
pnpm exec oxfmt --check --threads=1 src/commands/gateway-presence.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.ts src/commands/gateway-status/output.test.ts CHANGELOG.md
git diff --check upstream/main...HEAD

Result: focused Vitest passed (2 files, 10 tests), formatting passed, and diff whitespace passed.

Provenance: clear. The old warning behavior was carried forward from the gateway status warning path introduced around src/commands/gateway-status/output.ts by fe5819887b5; later reachability work kept the warning tied to reachable entries. This PR changes that exact warning decision point in src/commands/gateway-status/output.ts:129 and adds focused regression coverage.

Best-fix verdict: the source change is the right shape and keeps distinct, unknown, and different-port cases conservative. I would not merge until the docs/proof gaps above are resolved and the currently failing PR checks are green.

@giodl73-repo giodl73-repo force-pushed the fix-69135-gateway-probe-identity branch from 25bc974 to ecca770 Compare May 23, 2026 23:02
@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation gateway Gateway runtime labels May 23, 2026
@giodl73-repo giodl73-repo force-pushed the fix-69135-gateway-probe-identity branch from ecca770 to 250ba26 Compare May 24, 2026 14:10
@giodl73-repo
Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

Updated this PR on current main and added the missing live proof requested in review.

Validation run locally:

  • node scripts/run-vitest.mjs src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=dot -> 10 tests passed
  • ./node_modules/.bin/oxfmt --check --threads=1 CHANGELOG.md docs/cli/gateway.md docs/gateway/troubleshooting.md src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts
  • ./node_modules/.bin/oxlint src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts
  • git diff --check refs/remotes/origin/main...HEAD

Live behavior proof:

  • Started a temporary OpenClaw gateway and sshd inside a Linux network namespace to model the remote host.
  • Ran the real CLI path through /usr/bin/ssh: openclaw gateway probe --ssh root@<remote-ip>:<ssh-port> --ssh-identity <temp-key> --timeout 20000 --json.
  • Probe config also included gateway.remote.url=ws://<remote-ip>:<gateway-port>.
  • Result: ok: true, degraded: false, warnings: [], primaryTargetId: "sshTunnel".
  • Both sshTunnel and configRemote were reachable, had operator.read, and returned the same gateway self identity, so no multiple_gateways warning was emitted.

No merge performed.

@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented May 24, 2026

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

@clawsweeper clawsweeper Bot added proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels May 24, 2026
@giodl73-repo giodl73-repo force-pushed the fix-69135-gateway-probe-identity branch from 250ba26 to cb977a2 Compare May 24, 2026 17:04
Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

Updated the remaining linked gateway docs for the identity-based multiple_gateways semantics:

  • docs/gateway/index.md
  • docs/gateway/multiple-gateways.md

The stale target-count wording is now removed from the gateway docs, and the docs describe distinct or identity-ambiguous reachable gateways while noting that an SSH tunnel plus configured remote URL can be one gateway with multiple transports.

Validation run locally:

  • grep -R -n -E "multiple reachable gateways detected|more than one target answered|more than one target was reachable|multiple reachable gateways" docs/gateway docs/cli/gateway.md || true -> no stale matches
  • node scripts/run-vitest.mjs src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=dot -> 2 files, 10 tests passed
  • ./node_modules/.bin/oxfmt --check --threads=1 src/commands/gateway-presence.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.ts src/commands/gateway-status/output.test.ts CHANGELOG.md docs/cli/gateway.md docs/gateway/troubleshooting.md docs/gateway/index.md docs/gateway/multiple-gateways.md
  • ./node_modules/.bin/oxlint src/commands/gateway-presence.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.ts src/commands/gateway-status/output.test.ts
  • git diff --check

No merge performed.

@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented May 24, 2026

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

@clawsweeper clawsweeper Bot added rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels May 24, 2026
@giodl73-repo giodl73-repo force-pushed the fix-69135-gateway-probe-identity branch from cb977a2 to cd65418 Compare May 24, 2026 20:35
@giodl73-repo
Copy link
Copy Markdown
Contributor Author

Rebased onto current main and force-updated with an explicit lease. The failed checks-node-agentic-agents job timed out in src/agents/model-catalog-visibility.test.ts; that file passes locally after the rebase.\n\nValidation run locally in WSL from /root/src/openclaw-85791:\n-
ode scripts/run-vitest.mjs src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts src/agents/model-catalog-visibility.test.ts --reporter=dot - 4 files, 16 tests passed\n- pnpm exec oxfmt --check CHANGELOG.md docs/cli/gateway.md docs/gateway/index.md docs/gateway/multiple-gateways.md docs/gateway/troubleshooting.md src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts\n- pnpm exec oxlint src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts\n- pnpm lint --threads=2\n- git diff --check FETCH_HEAD...HEAD\n\nNo merge performed.

@giodl73-repo giodl73-repo force-pushed the fix-69135-gateway-probe-identity branch 2 times, most recently from fda0302 to f8259b6 Compare May 25, 2026 18:04
@clawsweeper clawsweeper Bot added rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels May 30, 2026
@giodl73-repo giodl73-repo force-pushed the fix-69135-gateway-probe-identity branch from 3079755 to 97b81a2 Compare May 31, 2026 14:33
Copy link
Copy Markdown
Contributor Author

Updated #85791 onto current main for Dependency Guard.

New signed head: 97b81a20bd207e971f4b99701b20aa6405fcecc5.
Base: 7ca77124fea04cdbb4308ee21b5cbd7af5d9a202.

Validation after the refresh:

  • OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/infra/system-presence.test.ts src/infra/system-presence.version.test.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=dot -> 4 files, 22 tests passed
  • ./node_modules/.bin/oxfmt --check --threads=1 src/infra/system-presence.ts docs/cli/gateway.md docs/gateway/index.md docs/gateway/multiple-gateways.md docs/gateway/troubleshooting.md src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts -> passed
  • ./node_modules/.bin/oxlint --tsconfig config/tsconfig/oxlint.core.json src/infra/system-presence.ts src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts -> 0 warnings, 0 errors
  • git diff --check origin/main...HEAD and git diff --check -> passed
  • codex review --base origin/main -> no actionable correctness issues found

All 7 rebased commits are signed. No config surface or plugin API surface changed. No merge performed.

@clawsweeper re-review

@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented May 31, 2026

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. and removed rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. labels May 31, 2026
Copy link
Copy Markdown
Contributor Author

Updated #85791 onto current main for Dependency Guard.

New signed head: 0799caef102ad70122828d59d78fadf9f00cfc3e.
Base: 63de51ab963250632e8e0b19f93b055d62cf5c13.

Validation after the refresh:

  • OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/infra/system-presence.test.ts src/infra/system-presence.version.test.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=dot -> 4 files, 22 tests passed
  • ./node_modules/.bin/oxfmt --check --threads=1 src/infra/system-presence.ts docs/cli/gateway.md docs/gateway/index.md docs/gateway/multiple-gateways.md docs/gateway/troubleshooting.md src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts -> passed
  • ./node_modules/.bin/oxlint --tsconfig config/tsconfig/oxlint.core.json src/infra/system-presence.ts src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts -> 0 warnings, 0 errors
  • git diff --check origin/main...HEAD and git diff --check -> passed
  • codex review --base origin/main -> no actionable correctness issues found

All 7 rebased commits are signed. No config surface or plugin API surface changed. No merge performed.

@clawsweeper re-review

@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented May 31, 2026

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

Refreshed #85791 onto current main for Dependency Guard.

Updates on signed head 14c2d29208a29459f1aa83401e02cbc2678247a9:

  • rebased onto main 144405e562789ace9fb51363c4ed08de5de48d30
  • maintainer edits are enabled
  • PR body validation refreshed

Validation in WSL from /tmp/openclaw-pr-85791-refresh:

  • OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/infra/system-presence.test.ts src/infra/system-presence.version.test.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=dot -> 4 files, 22 tests passed
  • ./node_modules/.bin/oxfmt --check --threads=1 src/infra/system-presence.ts docs/cli/gateway.md docs/gateway/index.md docs/gateway/multiple-gateways.md docs/gateway/troubleshooting.md src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts -> passed
  • ./node_modules/.bin/oxlint --tsconfig config/tsconfig/oxlint.core.json src/infra/system-presence.ts src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts -> 0 warnings, 0 errors
  • git diff --check origin/main...HEAD
  • git diff --check
  • git log --show-signature --format="%h %G? %s" origin/main..HEAD -> all 7 commits have good signatures
  • /home/giodl/.local/toolchains/node-v22.22.3-linux-x64/bin/codex review --base origin/main -> no blocking regressions found

No public config, plugin API, CLI flag, env var, migration, or plugin contract surface was added. No merge performed.

@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented May 31, 2026

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

Refreshed #85791 onto current main.

New signed head: d2e7b221a0f549bc826334c3229417dd74b7451d.
Current base: 7098e335bfe96f7999f4ff1de5641bf89393f413.

Validation in WSL from /home/giodl/src/openclaw-85529:

  • OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/infra/system-presence.test.ts src/infra/system-presence.version.test.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=dot -> 3 Vitest shards, 22 tests passed
  • node_modules/oxfmt/bin/oxfmt --check --threads=1 src/infra/system-presence.ts docs/cli/gateway.md docs/gateway/index.md docs/gateway/multiple-gateways.md docs/gateway/troubleshooting.md src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts -> passed
  • node_modules/oxlint/bin/oxlint --tsconfig config/tsconfig/oxlint.core.json src/infra/system-presence.ts src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts -> 0 warnings, 0 errors
  • git diff --check origin/main...HEAD and git diff --check -> passed
  • git log --show-signature --format="%H %G? %s" origin/main..HEAD -> all 7 commits have good signatures for giodl73@gmail.com

No config surface or plugin API surface changed. No merge performed.

@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented Jun 3, 2026

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

Copy link
Copy Markdown
Contributor Author

Refreshed this on current main (79a8dec44d037e3d8d4453a423c70308c69445ab) to pick up the lint cleanup that was causing the synthetic merge ref to fail check-lint.

New signed head: 96757656b4.

Validation rerun locally:

  • OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/infra/system-presence.test.ts src/infra/system-presence.version.test.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=dot (3 shards, 22 tests)
  • node_modules/oxfmt/bin/oxfmt --check --threads=1 src/infra/system-presence.ts docs/cli/gateway.md docs/gateway/index.md docs/gateway/multiple-gateways.md docs/gateway/troubleshooting.md src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts
  • node_modules/oxlint/bin/oxlint --tsconfig config/tsconfig/oxlint.core.json src/infra/system-presence.ts src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts
  • git diff --check origin/main...HEAD && git diff --check

No config, CLI, plugin API, or public surface changes.

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

Refreshed head 96757656b4 is current, and the previous automated review timed out before completing. Focused validation remains:

  • OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/infra/system-presence.test.ts src/infra/system-presence.version.test.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=dot -> 22 tests passed
  • formatter, linter, and diff checks passed
  • no config schema/options, CLI flags, plugin API/contract, env vars, or migration surface added

@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented Jun 4, 2026

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

Refreshed #85791 onto current main and addressed the latest formatting finding.

Updates on signed head 13e3c00f56f65b8690945bea9a666e3ab5b771e0:

  • rebased onto main 69df4c9136173b7387d4cf79ccd9121c93d49932
  • restored inline code formatting for changed CLI flags, warning codes, and operator.read docs text
  • no config schema/options, CLI flags, env vars, migrations, plugin APIs, or plugin contracts added or changed

Validation in WSL from /tmp/openclaw-pr-85791-current:

  • OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/infra/system-presence.test.ts src/infra/system-presence.version.test.ts src/commands/gateway-presence.test.ts src/commands/gateway-status/output.test.ts --reporter=dot -> 3 Vitest shards, 22 tests passed
  • node_modules/oxfmt/bin/oxfmt --check --threads=1 src/infra/system-presence.ts docs/cli/gateway.md docs/gateway/index.md docs/gateway/multiple-gateways.md docs/gateway/troubleshooting.md src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts -> passed
  • node_modules/oxlint/bin/oxlint --tsconfig config/tsconfig/oxlint.core.json src/infra/system-presence.ts src/commands/gateway-presence.test.ts src/commands/gateway-presence.ts src/commands/gateway-status/output.test.ts src/commands/gateway-status/output.ts -> 0 warnings, 0 errors
  • git diff --check origin/main...HEAD && git diff --check -> passed
  • git log --show-signature --oneline -8 -> all 8 commits have good signatures for giodl73@gmail.com

No merge performed.

@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented Jun 4, 2026

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

@giodl73-repo
Copy link
Copy Markdown
Contributor Author

Merged via squash.

Thanks @giodl73-repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands Command implementations docs Improvements or additions to documentation gateway Gateway runtime maintainer Maintainer-authored PR P2 Normal backlog priority with limited blast radius. proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. size: M status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants