[codex] improve iOS realtime talk mode#86355
Conversation
|
Codex review: found issues before merge. Reviewed May 25, 2026, 5:38 AM ET / 09:38 UTC. Summary PR surface: Source +1, Tests +10, Other +2053. Total +2064 across 17 files. Reproducibility: yes. for the blocking review finding: current main routes Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge Security Review findings
Review detailsBest possible solution: Land the direct iOS WebRTC path only after preserving or explicitly retiring gateway-relay compatibility, and after maintainer security/dependency signoff on the client-secret WebRTC boundary. Do we have a high-confidence way to reproduce the issue? Yes for the blocking review finding: current main routes Is this the best way to solve the issue? No; adding direct WebRTC may be the right direction, but this merge shape should preserve existing gateway-relay behavior or explicitly document and approve the compatibility break. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 033693843c26. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +1, Tests +10, Other +2053. Total +2064 across 17 files. View PR surface stats
Security concerns:
Acceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg 🔥 Warming up: real-behavior proof passed; findings, security review, or rank-up moves are still in progress. Hatch commandComment Hatchability rules:
What is this egg doing here?
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86bd10869c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
86bd108 to
8bfe3bb
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
bdf1887 to
3f5aedb
Compare
|
Merged via squash.
Thanks @ngutman! |
Summary
Verification
swiftformat --config config/swiftformat apps/ios/Sources/Voice/TalkRealtimeWebRTCSession.swiftswiftlint lint --config apps/ios/.swiftlint.yml apps/ios/Sources/HomeToolbar.swift apps/ios/Sources/RootCanvas.swift apps/ios/Sources/Voice/TalkModeManager.swift apps/ios/Sources/Voice/TalkRealtimeWebRTCSession.swiftgit diff --checkxcodebuild -project apps/ios/OpenClaw.xcodeproj -scheme OpenClaw -configuration Debug -destination 'id=6A19D82B-4EA6-5D67-B3A7-0AB3B71B550C' buildxcrun devicectl device install app --device 6A19D82B-4EA6-5D67-B3A7-0AB3B71B550C <built OpenClaw.app>xcrun devicectl device process launch --device 6A19D82B-4EA6-5D67-B3A7-0AB3B71B550C ai.openclaw.ios.test.guti-gzs353x62eKnown warning: the full iOS build still reports the pre-existing
OnboardingWizardView.swifttype_body_lengthSwiftLint warning.Real behavior proof
Behavior addressed: iOS talk mode can request talk access, start direct realtime voice, show status above the toolbar, animate on microphone speech, and keep the speaking waveform active until assistant playback drains.
Real environment tested: physical iPhone target
6A19D82B-4EA6-5D67-B3A7-0AB3B71B550Cwith bundleai.openclaw.ios.test.guti-gzs353x62e.Exact steps or command run after this patch: built the iOS app with
xcodebuild, installed it withxcrun devicectl device install app, and launched it withxcrun devicectl device process launch.Evidence after fix: build, install, and launch all completed successfully; targeted SwiftLint on the changed talk UI/realtime files passed with 0 violations.
Observed result after fix: the current branch build is installed and running on the device for manual voice-mode testing.
What was not tested: no automated audio-output duration assertion; final waveform/audio sync is validated manually on the physical device.