fix(discord): accumulate reasoning progress deltas#87339
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed May 29, 2026, 2:49 AM ET / 06:49 UTC. Summary PR surface: Source -1, Tests +29. Total +28 across 3 files. Reproducibility: yes. for source-level reproduction: current main formats reasoning before the draft-preview merge, and the merge path treats Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land only after maintainer review has redacted live Discord progress-mode proof and any sibling PR rebase preserves the raw-then-format reasoning behavior. Do we have a high-confidence way to reproduce the issue? Yes for source-level reproduction: current main formats reasoning before the draft-preview merge, and the merge path treats Is this the best way to solve the issue? Yes, the proposed code path is the narrow maintainable fix: keep reasoning payloads raw for merge semantics, then format once for display. The remaining gap is proof and merge-order safety, not an obvious code defect. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 31f3914082df. Label changesLabel justifications:
Evidence reviewedPR surface: Source -1, Tests +29. Total +28 across 3 files. View PR surface stats
Acceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
6086081 to
c626d4d
Compare
|
Refreshed #87339 onto current Focused WSL validation after the refresh:
This refresh should replace the prior |
This comment was marked as spam.
This comment was marked as spam.
c626d4d to
444363d
Compare
Summary
Fixes #83983.
Discord progress-mode reasoning updates were formatting each reasoning callback with the display
Thinking...wrapper before draft-preview merge logic saw it. Since the merge logic treatsThinking.../Reasoning:prefixed text as a full snapshot, Codex app-server delta chunks like"Considering"," plugin"," installation","!"could replace each other until only the final tiny chunk remained visible.This keeps reasoning stream payloads raw until
pushReasoningProgress()merges delta/snapshot semantics, then applies the existing reasoning display formatter once for the stable progress line.No config surface or plugin surface changes.
Proof