Fix systemd crash loop: forward SIGTERM during entry.ts respawn#933
Closed
roshanasingh4 wants to merge 1 commit intoopenclaw:mainfrom
Closed
Fix systemd crash loop: forward SIGTERM during entry.ts respawn#933roshanasingh4 wants to merge 1 commit intoopenclaw:mainfrom
roshanasingh4 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
|
Thanks Roshan! |
Contributor
Author
You're Welcome Peter... |
steipete
added a commit
that referenced
this pull request
Jan 15, 2026
Co-authored-by: Roshan Singh <roshanasingh4@users.noreply.github.com>
Contributor
|
Landed on main after rebasing onto a temp branch. What changed:
Tests: Commits: Thanks @roshanasingh4! |
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…ngh4) Co-authored-by: Roshan Singh <roshanasingh4@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #931
Problem
src/entry.tsconditionally respawns itself to inject--disable-warning=ExperimentalWarningintoNODE_OPTIONS. Today that respawn usedspawnSync(), which blocks the parent process. When running under systemd withKillMode=process,systemctl stoponly terminates the parent PID. The spawned child (the actual gateway process holding the port) can survive as an orphan and keep the gateway port bound, causing restart loops withEADDRINUSE.Fix
Switch the respawn from
spawnSync()to a non-blockingspawn()wrapper that forwards termination signals (SIGTERM/SIGINT/SIGHUP/SIGQUIT) from the parent to the child. This ensures a systemd stop will also terminate the actual gateway process even underKillMode=process.Tests
Adds a regression test for the signal-forwarding helper that simulates the parent receiving SIGTERM and asserts the child process is terminated and releases its listening port.