Fix model fallback crash on undefined provider/model (#946)#954
Merged
steipete merged 2 commits intoopenclaw:mainfrom Jan 15, 2026
Merged
Conversation
steipete
force-pushed
the
fix/946-openai-completions-trim
branch
from
dc9cde6 to
c043e97
Compare
Contributor
|
Landed via temp rebase onto main.\n\n- Gate: pnpm lint && pnpm build && pnpm test\n- Land commit: c043e97\n- Merge commit: fc4aa9a\n\nThanks @roshanasingh4! |
michaelhaessig
pushed a commit
to michaelhaessig/clawdbot
that referenced
this pull request
Jan 15, 2026
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…pletions-trim Fix model fallback crash on undefined provider/model (openclaw#946)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #946.
Problem
When using a custom local provider with
api: "openai-completions"(oropenai-responses), the gateway could crash before any HTTP request with:Cannot read properties of undefined (reading 'trim')This happens because the model fallback code called
.trim()onprovider/modelwithout guarding against undefined values during preflight model selection.Fix
Coerce
providerandmodelto strings and fall back to defaults when missing, instead of calling.trim()directly.Tests
Adds a regression test that passes undefined
provider/modeltorunWithModelFallbackand asserts it safely defaults.