Skip to content

Fix actor isolation crash in fetchReminders #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Noah-Ribaudo wants to merge 1 commit into from
Closed

Fix actor isolation crash in fetchReminders #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Sources/RemindCore/EventKitStore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,24 @@ public actor RemindersStore {
}

private func fetchReminders(in calendars: [EKCalendar]) async -> [ReminderItem] {
await withCheckedContinuation { continuation in
// Capture calendar for use in closure (avoids actor isolation issues)
let cal = self.calendar
return await withCheckedContinuation { continuation in
let predicate = eventStore.predicateForReminders(in: calendars)
eventStore.fetchReminders(matching: predicate) { reminders in
// Extract all data from EKReminder objects here, before crossing isolation boundary
let mapped = (reminders ?? []).map { reminder in
self.item(from: reminder)
ReminderItem(
id: reminder.calendarItemIdentifier,
title: reminder.title ?? "",
notes: reminder.notes,
isCompleted: reminder.isCompleted,
completionDate: reminder.completionDate,
priority: ReminderPriority(eventKitValue: Int(reminder.priority)),
dueDate: reminder.dueDateComponents.flatMap { cal.date(from: $0) },
listID: reminder.calendar.calendarIdentifier,
listName: reminder.calendar.title
)
}
continuation.resume(returning: mapped)
}
Expand Down