This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Update test-dataloader.yaml #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| token: ${{ secrets.REPO_ACCESS_TOKEN }} | ||
| repository: openclimatefix/nowcasting_dataloader | ||
| event-type: my-event | ||
| event-type: dataset-update |
Contributor
There was a problem hiding this comment.
could you add github ref int there too?
Contributor
Author
There was a problem hiding this comment.
Not for the event-type I don't think, because the one in nowcasting-dataloader has to have the same name to get the event, and it wouldn't know what the ref is. We actually pass the ref in the payload sent with the event, just don't do anything with it on the other side right now
Contributor
There was a problem hiding this comment.
ah ok,
Could it be nowcasting-dataset-update?
Contributor
Author
There was a problem hiding this comment.
We could use the ref to checkout that commit, I think? https://github.com/marketplace/actions/repository-dispatch I'm still figuring out all these actions
peterdudfield
approved these changes
Oct 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Corresponding update to workflow title as in nowcasting-dataloader
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist: