Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@JackKelly
Copy link
Contributor

Pull Request

Description

Remove the function load_configuration_from_gcs() because load_yaml_configuration can load from any compute environment 🙂

Fixes #153

How Has This Been Tested?

Tests all pass

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@JackKelly JackKelly requested a review from jacobbieker October 26, 2021 09:22
@JackKelly JackKelly self-assigned this Oct 26, 2021
Copy link
Contributor

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JackKelly JackKelly merged commit 5d03c35 into main Oct 26, 2021
@JackKelly JackKelly deleted the jack/remove_load_configuration_from_gcs branch October 26, 2021 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use fsspec and/or pathy to provide a unified interface to GCP, AWS, and local filesystems

3 participants