This repository was archived by the owner on Sep 11, 2023. It is now read-only.
make pv coords more relastic #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # nowcasting_dataset/data_sources/fake.py
flowirtz
approved these changes
Nov 17, 2021
Contributor
flowirtz
left a comment
flowirtz
left a comment
There was a problem hiding this comment.
LGTM, just a a bunch of nits :)
| return Topographic(xr_dataset) | ||
|
|
||
|
|
||
| def add_uk_centroid_osgb(x, y): |
Contributor
There was a problem hiding this comment.
I'm a bit lost in this function.
What does x and y do to the random lat/lon values?
Is it more like "create a random OSGB value in the centre of UK influenced by x,y "?
I think it would help to change the comment and make the function name a bit more descriptive.
…ke-data-update # Conflicts: # nowcasting_dataset/data_sources/fake.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (small)
Description
edit fake coords to make them more realistic. They also centres in the UK
helps #openclimatefix-archives/nowcasting_utils#46
How Has This Been Tested?
They have been tested by being plotted
Checklist: