This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Bug/manager #403
Merged
Bug/manager #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will resolve this conflicts |
# Conflicts: # nowcasting_dataset/data_sources/nwp/nwp_data_source.py
JackKelly
approved these changes
Nov 16, 2021
| # if t0_dt is not on the hour, e.g. 13.05. | ||
| # Then if the history_minutes is 1 hours, | ||
| # so start_dt will be 12.05, but we want to the 12.00 time step too | ||
| start_dt = start_dt.floor("H") |
Contributor
There was a problem hiding this comment.
Very good catch; and very elegant fix! Nice!
(And perfect timing too, because I think I just bumped into the same bug: #410 🙂 )
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Managerto initialise data sources and make batchesFixes #
How Has This Been Tested?
unitest tests
added one for nwp - load data not on hour
added one for manger too - initialise data source and get batches
No
Yes
Checklist: