This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Fix "RuntimeError: Example is wrong shape" #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackKelly
changed the base branch from
main
to
jack/temporary-merge-of-log-to-files-and-manger-sun
JackKelly
changed the base branch from
jack/temporary-merge-of-log-to-files-and-manger-sun
to
main
| zarr_path, engine="zarr", consolidated=consolidated, mode="r", chunks=None | ||
| ) | ||
|
|
||
| ukv = nwp["UKV"] |
Contributor
There was a problem hiding this comment.
is the reversing needed for other channels?
Contributor
There was a problem hiding this comment.
I may have miss understood here - UKV might not be a channel. Perhaps add a comment why "UKV" is selected
Contributor
Author
There was a problem hiding this comment.
Ah, yes, good point! UKV is the name of the (one and only) DataArray in the Zarr Dataset. You're right, UKV isn't a channel. UKV is the name of the DataArray which holds all the channels (the channels are represented as a dimension in the DataArray). I'll add a comment! Thanks!
peterdudfield
approved these changes
Nov 16, 2021
Contributor
peterdudfield
left a comment
peterdudfield
left a comment
There was a problem hiding this comment.
Looks good.
- just a small comment
- looks like a few conflicts, but im sure you can merge main into this first
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
PLEASE NOTE THAT THERE ARE ONLY TWO SMALL CHANGES IN THIS PR IN
nwp_data_source.py: HERE AND HEREThe reason GitHub says 7 files have changed is because I merged a bunch of other bug fixes into this branch. Specifically:
Good news:
prepare_ml_data.pynow creates NWP batches! And fairly fast, too (about 1 per second).Fixes #410
How Has This Been Tested?
prepare_ml_data.pyruns successfullyChecklist: