Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@JackKelly
Copy link
Contributor

@JackKelly JackKelly commented Nov 16, 2021

Pull Request

Description

Print combined log to stdout.

Save combined log to self.config.output_data.filepath / combined.log

Save individual logs for each DataSource in
self.config.output_data.filepath / <data_source>.log

Fixes #156

How Has This Been Tested?

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@JackKelly JackKelly added the enhancement New feature or request label Nov 16, 2021
@JackKelly JackKelly self-assigned this Nov 16, 2021
@JackKelly JackKelly marked this pull request as ready for review November 16, 2021 19:01
Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,

As a big tester - I would always encourage a test to be writtne to check this works - or make sure it doesnt break in the future. I think its find for a dummy test to be wrtiten and then a TODO added with an issue. This could be done in test_manager for example

@JackKelly
Copy link
Contributor Author

Good idea! I've added TODOs to the code, and made a note on issue #322. Thanks!

@JackKelly JackKelly merged commit 2d821f4 into main Nov 16, 2021
@JackKelly JackKelly deleted the jack/log-to-files branch November 16, 2021 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prepare_ml_data.py should save separate logs to OutputData.filepath/<SplitName>/<DataSource>

3 participants