This repository was archived by the owner on Sep 11, 2023. It is now read-only.
update to split on training in one year, test after a date #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JackKelly do you think its ok harding coding them in 'manager.py' or should I move them to config.model.py? |
Contributor
|
I think hard coding is fine for now 🙂 But please create a new issue to remind us to make this into a config option in early 2022 🙂 |
JackKelly
approved these changes
Nov 17, 2021
Contributor
JackKelly
left a comment
JackKelly
left a comment
There was a problem hiding this comment.
LGTM! Thanks! Didn't realise it would be this simple: Your splitting code is nice and easy to use 🙂
Contributor
Author
Thats the beauty of making everything module |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
change split method to
values were hard in by a issue has been made to mvoe this to a config file - #426
Fixes #390
How Has This Been Tested?
unittests
Checklist: