Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

add tests bk in #535

Merged
merged 2 commits into from
Dec 10, 2021
Merged

add tests bk in #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cacc3d1
add tests bk in
peterdudfield Dec 10, 2021
281b55b
tidy
peterdudfield Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion nowcasting_dataset/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ def configure_loggers(
log_filename = self.config.output_data.filepath / f"{data_source_name}.log"
nd_utils.configure_logger(
log_level=log_level,
# TODO: Fix bug #467: satellite.log file is not being appended to.
logger_name=f"nowcasting_dataset.data_sources.{data_source_name}",
handlers=[logging.FileHandler(log_filename, mode="a")],
)
Expand Down
7 changes: 0 additions & 7 deletions tests/data_sources/gsp/test_gsp_pvlive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
from datetime import datetime

import pandas as pd
import pytest
import pytz

from nowcasting_dataset.data_sources.gsp.pvlive import (
Expand All @@ -11,7 +10,6 @@
)


@pytest.mark.skip("Skip due to PVlive server issues: #395")
def test_load_gsp_raw_data_from_pvlive_one_gsp_one_day():
"""
Test that one gsp system data can be loaded, just for one day
Expand All @@ -28,7 +26,6 @@ def test_load_gsp_raw_data_from_pvlive_one_gsp_one_day():
assert "generation_mw" in gsp_pv_df.columns


@pytest.mark.skip("Skip due to PVlive server issues: #395")
def test_load_gsp_raw_data_from_pvlive_one_gsp_one_day_not_normalised():
"""
Test that one gsp system data can be loaded, just for one day, and is normalized correctly
Expand All @@ -49,7 +46,6 @@ def test_load_gsp_raw_data_from_pvlive_one_gsp_one_day_not_normalised():
assert gsp_pv_df["generation_mw"].max() <= 1


@pytest.mark.skip("Skip due to PVlive server issues: #395")
def test_load_gsp_raw_data_from_pvlive_one_gsp():
"""
Test that one gsp system data can be loaded
Expand All @@ -67,7 +63,6 @@ def test_load_gsp_raw_data_from_pvlive_one_gsp():
assert "generation_mw" in gsp_pv_df.columns


@pytest.mark.skip("Skip due to PVlive server issues: #395")
def test_load_gsp_raw_data_from_pvlive_many_gsp():
"""
Test that one gsp system data can be loaded
Expand All @@ -84,7 +79,6 @@ def test_load_gsp_raw_data_from_pvlive_many_gsp():
assert "generation_mw" in gsp_pv_df.columns


@pytest.mark.skip("Skip due to PVlive server issues: #395")
def test_get_installed_capacity():
"""
Test thhat we can get installed capacity
Expand All @@ -95,4 +89,3 @@ def test_get_installed_capacity():
assert len(installed_capacity) == 3
assert "installedcapacity_mwp" == installed_capacity.name
assert installed_capacity.iloc[0] == 342.02623
assert installed_capacity.iloc[2] == 308.00432