Skip to content

fix(createforecast): Correctly set empty value metadata to NULL#128

Merged
devsjc merged 1 commit intomainfrom
devsjc/empty-values-metadata
Feb 27, 2026
Merged

fix(createforecast): Correctly set empty value metadata to NULL#128
devsjc merged 1 commit intomainfrom
devsjc/empty-values-metadata

Conversation

@devsjc
Copy link
Contributor

@devsjc devsjc commented Feb 27, 2026

Contribution Checklist

  • Have you followed the Open Climate Fix Contribution Guidelines?
  • [] Have you referenced the Issue this PR addresses, where applicable?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added a summary of the changes?
  • Have you written new tests for your changes, where applicable?
  • Have you successfully run make lint with your changes locally?
  • Have you successfully run make test with your changes locally?

Warning

PRs may be closed if all the above boxes are not checked.

Changes in this Pull Request

Updates the CreateForecast logic so that empty metadata structs on the value object are set to nil in order to write NULLs to the database and pass the column constraint.

@peterdudfield
Copy link
Contributor

Ive approved as long as the tests pass

@devsjc devsjc merged commit 2055070 into main Feb 27, 2026
3 checks passed
@devsjc devsjc deleted the devsjc/empty-values-metadata branch February 27, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants