Numpy conversion consolidation function#396
Merged
felix-e-h-p merged 5 commits intomainfrom Feb 25, 2026
Merged
Conversation
dfulu
reviewed
Feb 24, 2026
dfulu
reviewed
Feb 24, 2026
dfulu
reviewed
Feb 24, 2026
dfulu
requested changes
Feb 24, 2026
Member
dfulu
left a comment
dfulu
left a comment
There was a problem hiding this comment.
@felix-e-h-p this looks really good. Really nice to get rid of those SampleKey classes.
I've left a couple of comments. On the t0_idx I think we should strip it all out except for on the generation data. The original pipeline wasn't using those so I think we should just remove support for the NWP and sat t0_idxs. In the original we were just adding {"t0_idx": self.t0_idx} to each sample and I think we should just stick to that
dfulu
requested changes
Feb 25, 2026
Member
dfulu
left a comment
dfulu
left a comment
There was a problem hiding this comment.
Looks really good @felix-e-h-p. One last thing, can you strip out the merge_dicts() function since this change means we don't need it anymore
dfulu
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate numpy sample conversion into a single function - as referenced in #368 (think also related to #255)
Implemented single convert_to_numpy_sample(sample, t0) in convert.py:
All related tests updated to use string keys instead of now old class attributes.