Skip to content

Fix version#16

Merged
peterdudfield merged 2 commits intomainfrom
fix-version
May 24, 2023
Merged

Fix version#16
peterdudfield merged 2 commits intomainfrom
fix-version

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented May 24, 2023

Pull Request

Description

Fix version

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from dfulu May 24, 2023 13:31
@peterdudfield peterdudfield self-assigned this May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #16 (8446ae6) into main (69fa36d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          21       21           
  Lines        1442     1442           
=======================================
  Hits         1012     1012           
  Misses        430      430           
Impacted Files Coverage Δ
pvnet/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterdudfield peterdudfield merged commit 33cc3ac into main May 24, 2023
@peterdudfield peterdudfield deleted the fix-version branch May 24, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants