Skip to content

fix: issue #167 (fix position of snackbar) #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guruz merged 1 commit into from
May 30, 2026
Merged

fix: issue #167 (fix position of snackbar) #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion opencloudApp/src/main/java/eu/opencloud/android/extensions/ActivityExt.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ fun Activity.showMessageInSnackbar(
message: CharSequence,
duration: Int = Snackbar.LENGTH_LONG
) {
Snackbar.make(findViewById(layoutId), message, duration).show()
// edge-to-edge
val view = if (layoutId == android.R.id.content) window.decorView else findViewById(layoutId)
Snackbar.make(view, message, duration).show()
}

fun Activity.showErrorInToast(
Expand Down
8 changes: 1 addition & 7 deletions opencloudApp/src/main/java/eu/opencloud/android/ui/activity/BaseActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,13 +318,7 @@ public void dismissLoadingDialog() {
* @param message Message to show.
*/
public void showSnackMessage(String message) {
final View rootView = findViewById(android.R.id.content);

if (rootView == null) {
// If root view is not available don't let the app brake. show the notification anyway.
Toast.makeText(this, message, Toast.LENGTH_LONG).show();
return;
}
final View rootView = getWindow().getDecorView();
Snackbar.make(rootView, message, Snackbar.LENGTH_LONG).show();
}
}
4 changes: 2 additions & 2 deletions opencloudApp/src/main/java/eu/opencloud/android/ui/activity/FileActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,15 +277,15 @@ protected void showRequestAccountChangeNotice(String errorMessage, boolean mustC
.setCancelable(false)
.show();
} else {
Snackbar.make(findViewById(android.R.id.content), errorMessage, Snackbar.LENGTH_INDEFINITE)
Snackbar.make(getWindow().getDecorView(), errorMessage, Snackbar.LENGTH_INDEFINITE)
.setAction(R.string.auth_oauth_failure_snackbar_action, v ->
requestCredentialsUpdate())
.show();
}
}

protected void showRequestRegainAccess() {
Snackbar.make(findViewById(android.R.id.content), R.string.auth_oauth_failure, Snackbar.LENGTH_INDEFINITE)
Snackbar.make(getWindow().getDecorView(), R.string.auth_oauth_failure, Snackbar.LENGTH_INDEFINITE)
.setAction(R.string.auth_oauth_failure_snackbar_action, v ->
requestCredentialsUpdate())
.show();
Expand Down
4 changes: 2 additions & 2 deletions opencloudApp/src/main/java/eu/opencloud/android/ui/preview/PreviewVideoActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,15 +418,15 @@ class PreviewVideoActivity : FileActivity(), Player.Listener, OnPrepareVideoPlay
val fileToSetAsAvailableOffline = ArrayList<OCFile>()
fileToSetAsAvailableOffline.add(file)
fileOperationsViewModel.performOperation(SetFilesAsAvailableOffline(fileToSetAsAvailableOffline))
Snackbar.make(binding.root, R.string.confirmation_set_available_offline, Snackbar.LENGTH_LONG).show()
Snackbar.make(window.decorView, R.string.confirmation_set_available_offline, Snackbar.LENGTH_LONG).show()
true
}

R.id.action_unset_available_offline -> {
val fileToUnsetAsAvailableOffline = ArrayList<OCFile>()
fileToUnsetAsAvailableOffline.add(file)
fileOperationsViewModel.performOperation(UnsetFilesAsAvailableOffline(fileToUnsetAsAvailableOffline))
Snackbar.make(binding.root, R.string.confirmation_unset_available_offline, Snackbar.LENGTH_LONG).show()
Snackbar.make(window.decorView, R.string.confirmation_unset_available_offline, Snackbar.LENGTH_LONG).show()
true
}

Expand Down
Loading