Add original checksums for TUS uploads#185
Open
zerox80 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds client-computed SHA1 checksums for TUS uploads so OpenCloud receives the checksum of the original upload source instead of a late checksum over whatever file is about to be uploaded.
This PR also includes the content-URI cache validation from #184 because that PR is not merged yet. Without that validation, a stale partial cache file could still be reused before the checksum path has a trustworthy original source.
Changes
content://stream before creating a TUS upload.tusUploadChecksumcolumn assha1:<hex>so retries and recreated sessions use the same source checksum.Upload-Metadataaschecksum = SHA1 <hex>.Upload-Checksum: sha1 <base64(raw chunk sha1)>on each TUS PATCH.400/460) as a retryable TUS failure instead of falling back to unchecked PUT..partfiles before upload.Validation
git diff --checkpassed.git diff --cached --checkpassed before commit../gradlew.bat :opencloudApp:testOriginalDebugUnitTestcould not run locally:JAVA_HOMEis not set and nojavaexecutable is available in PATH../gradlew.bat :opencloudComLibrary:testDebugUnitTestcould not run locally for the same Java environment reason../gradlew.bat :opencloudApp:compileOriginalDebugKotlincould not run locally for the same Java environment reason.Fixes #181 when combined with the included partial-cache validation.
Depends on / supersedes #184 if this PR is merged first.