Conversation
TheOneRing
force-pushed
the
work/vfs_mount
branch
5 times, most recently
from
03d782f to
7b74175
Compare
TheOneRing
force-pushed
the
work/vfs_mount
branch
4 times, most recently
from
e98b5bf to
1beb67c
Compare
TheOneRing
force-pushed
the
work/vfs_mount
branch
2 times, most recently
from
0d405a5 to
fd41181
Compare
dragotin
approved these changes
Feb 11, 2026
Member
dragotin
left a comment
dragotin
left a comment
There was a problem hiding this comment.
Yes, lets go and do more testing.
| const auto result = VfsPluginManager::instance().checkAvailability(path(), _vfs->mode()); | ||
| if (!result) { | ||
| error = result.error(); | ||
| } else if (error.isEmpty()) { |
Member
There was a problem hiding this comment.
Hm, I think it would be nicer to have the vfs preperation in its own method rather than stuffing it into checkLocalPath(). How about prepVfs() or something, just to make the purpose more clear?
TheOneRing
force-pushed
the
work/vfs_mount
branch
2 times, most recently
from
6d9ec27 to
1917c2b
Compare
TheOneRing
force-pushed
the
work/vfs_mount
branch
from
1917c2b to
63b59a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could split the changes here in two reviews if needed.
The refactoring of the vfs cases to make
checkAvailabilityavailable without an instance of a backend and the mount/unmount part.I'm currently not happy with the name
checkAvailabilityas it does more than that and takes care of the unmounting of the stale mounts.Depends on: dragotin/openvfs#22