Conversation
| --- | ||
|
|
||
| # Docker Compose | ||
| # **Docker Compose Installation Guide** |
There was a problem hiding this comment.
The wording installation is misleading, users could get the impression, this is a guide to install docker compose
fschade
left a comment
fschade
left a comment
There was a problem hiding this comment.
some findings... nothing crucial and if you ask me optional, up do you! Thanks, good contribution!
|
|
||
| ## **Prerequisites:** | ||
| - **Linux**, **Mac** or **Windows** Subsystem for Linux [(WSL)](https://learn.microsoft.com/en-us/windows/wsl/install) | ||
| - [**Git**](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git) |
There was a problem hiding this comment.
not necessarily, the file can be downloaded from GH too...
There was a problem hiding this comment.
I will let it in, because we need sometimes to install it before. Only to be safe ;)
There was a problem hiding this comment.
I think it is a bit of overkill to clone the whole repo just for the dir. Maybe we need another "quick script" that people can call like wget https://opencloud.eu/docker-composition or so...
Out of scope of this PR tough
|
|
||
| ### 1. Download | ||
|
|
||
| Download the `opencloud_full` folder (this folder contains a multi-file Docker Compose configuration): |
There was a problem hiding this comment.
That's misleading, you speak about download the folder but next step you are cloning the whole repo
Co-authored-by: Alex <abackermann91@gmail.com>
Co-authored-by: Alex <abackermann91@gmail.com>
Co-authored-by: Alex <abackermann91@gmail.com>
|
|
||
| ```bash | ||
| apt update && apt upgrade -y | ||
| ``` |
There was a problem hiding this comment.
This does not only update the package list (that is apt update, but updates the entire system. Nothing wrong with that.
However, I would still not write it that detailed. The entire article is distro agnostic, but this is a debian/ubuntu only command, so I would rather recommend something like Make sure your system packages are updated according to your base system. or so.
There was a problem hiding this comment.
we can add for other distro the commands in a separate tab.
But I think we need a decision if we only should describe ubuntu or other distro too. If only Ubuntu you are right, we need to write it.
| ```bash | ||
| apt update && apt upgrade -y | ||
| ``` | ||
| Install Docker following the [official Docker guide](https://docs.docker.com/engine/install/ubuntu/#install-using-the-repository) |
There was a problem hiding this comment.
Again a reference to Ubuntu. Either it is targeted at Ubuntu, than we should change the Prerequisite above saying that, or we keep it distro agnostic.
| You should see a security warning because the staging certificate is not fully trusted. | ||
| Same should appear with the other domains you are using. | ||
|
|
||
| Example with Chrome browser: |
There was a problem hiding this comment.
Nitpicking: We promote open source - which Chrome is not particularly. Maybe consider using Firefox for these kind of things.
| nano .env | ||
| ``` | ||
|
|
||
| Comment out the staging server: |
There was a problem hiding this comment.
I think in English you can drop the "out" ...
|
|
||
| ## **Prerequisites:** | ||
| - **Linux**, **Mac** or **Windows** Subsystem for Linux [(WSL)](https://learn.microsoft.com/en-us/windows/wsl/install) | ||
| - [**Git**](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git) |
There was a problem hiding this comment.
I think it is a bit of overkill to clone the whole repo just for the dir. Maybe we need another "quick script" that people can call like wget https://opencloud.eu/docker-composition or so...
Out of scope of this PR tough
|
|
||
| ### Troubleshooting | ||
|
|
||
| If you encounter any issues or errors, try finding a solution here: |
There was a problem hiding this comment.
| If you encounter any issues or errors, try finding a solution here: | |
| If you encounter any issues or errors, you will find a solution here: |
|
@dragotin I made some changes according to your suggestions. |
5 participants
No description provided.