No notification triggered for `.zip` virus file

[prashant-gurung899]

Describe the bug

When eicar_com.zip is uploaded, no notification is triggered. But notification is triggered for eicar.com virus file.

Steps to reproduce

1. Upload eicar_com.zip.

curl -u admin:admin "https://localhost:9200/ocs/v2.php/apps/notifications/api/v1/notifications?format=json" -vk | jq

Expected behavior

Expected to get notification like: Virus found in eicar_com.zip. Upload not possible. Virus: Win.Test.EICAR_HDB-1

Actual behavior

No notification for eicar_com.zip file.

noNotif.webm

{
  "ocs": {
    "meta": {
      "message": "",
      "status": "",
      "statuscode": 200
    },
    "data": null
  }
}

Setup

Run clamav:

docker run -d -p 3310:3310 owncloudci/clamavd

Run opencloud:

PROXY_ENABLE_BASIC_AUTH=true OCIS_LOG_LEVEL=debug IDM_CREATE_DEMO_USERS=true OC_INSECURE=true ANTIVIRUS_SCANNER_TYPE="clamav" ANTIVIRUS_CLAMAV_SOCKET="tcp://host.docker.internal:3310" POSTPROCESSING_STEPS="virusscan" OC_ASYNC_UPLOADS=true OC_ADD_RUN_SERVICES="antivirus" opencloud/bin/opencloud server

Details

OpenCloud 1.0.0+22b52a776 Community
OpenCloud Web UI 1.0.0

[individual-it]

the tests for that fail when running with dav/... path https://ci.opencloud.eu/repos/3/pipeline/429/69
but pass when running with remote.php/dav path
@prashant-gurung899 could you confirm if that is true

[individual-it]

@prashant-gurung899 forget my last comment, I think that was more of an issue in the expected-to-fail file

[fschade]

@prashant-gurung899 im unable to reproduce the issue, can you please re-check with the latest oc version? I also see that your zip file has 0 bytes, are you sure it contains the eicar file?

i use the following files for testing:

• https://secure.eicar.org/eicar.com.txt
• https://www.eicar.org/download/eicar_com-zip

[prashant-gurung899]

@prashant-gurung899 im unable to reproduce the issue, can you please re-check with the latest oc version? I also see that your zip file has 0 bytes, are you sure it contains the eicar file?

@fschade
You're right. I just rechecked and realized the zip file I used was 0 bytes, which explains why the issue didn’t reproduce. Thanks for pointing it out!
I have also made a new PR changing the zip file here because we had the 0 byte zip file for testing which made the tests fail.
I will also refactor the tests accordingly in the same PR because they were put into expected-to-fail list.
CC @individual-it