Improve opensearch highlighting, fix favorites#2514
Merged
fschade merged 6 commits intoopencloud-eu:mainfrom Mar 25, 2026
Merged
Improve opensearch highlighting, fix favorites#2514fschade merged 6 commits intoopencloud-eu:mainfrom
fschade merged 6 commits intoopencloud-eu:mainfrom
Conversation
The new index allows for faster highlighing uses the fvh highlighter and searching for favorites.
Co-authored-by: Florian Schade <f.schade@icloud.com>
aduffeck
force-pushed
the
improve-opensearch
branch
from
1525739 to
de5deff
Compare
Member
|
Good work! There is an API test related to stop words failing. |
Keeping the stop words leads to slightly bigger indexes but fixes chopped up highlights of search results and phrase accuracy during search.
aduffeck
force-pushed
the
improve-opensearch
branch
from
de5deff to
dea3062
Compare
|
Member
Author
Yes, we currently enable stop word filtering by default which leads to phrase accuracy issues during search and chopped up highlighting results. I would like to change the default to keep stop words. Here's an example showing both versions: Content: 
Highlights: 
Indexing stop words slightly increases the index size, but I would argue that the current highlighting results are very confusing and not helpful at all. |
fschade
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new opensearch index which
Note This is an incompatible change. Users of the opensearch backend will have to drop their old index and rebuild it using