Skip to content

Add emblem, only use background image when set#145

Merged
AlexAndBear merged 2 commits into
mainfrom
redesign-plain
Feb 11, 2025
Merged

Add emblem, only use background image when set#145
AlexAndBear merged 2 commits into
mainfrom
redesign-plain

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

Related Issue

  • Fixes <issue_link>

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • New feature (an additional functionality that doesn't break existing code)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear requested a review from kulmann February 11, 2025 11:35
@AlexAndBear

Copy link
Copy Markdown
Member Author

needs opencloud-eu/opencloud#187

bottom: -2vh;
width: 20vw;
height: 20vw;
z-index: 0;

@AlexAndBear AlexAndBear Feb 11, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

z-index can be removed

z-index: 0;

@media (max-width: 640px) {
display: none !important;

@AlexAndBear AlexAndBear Feb 11, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if we need important

@AlexAndBear AlexAndBear changed the title Add embled, only use background image when set Add emblem, only use background image when set Feb 11, 2025

@kulmann kulmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome! 😍

I have a bonus-request 😁 Since the logo is not part of the plain layout, could you check all the plain layout pages and add the logo above the card where it's not present yet? At least the public link resolve page doesn't have it. The access denied page has it - that looks much better than without. But of course fine as a followup...

@AlexAndBear

Copy link
Copy Markdown
Member Author

@kulmann ofc (: to-da-lo

@AlexAndBear AlexAndBear merged commit 82baded into main Feb 11, 2025
@AlexAndBear AlexAndBear deleted the redesign-plain branch February 11, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants