Skip to content

[with-tracing] fix: e2e-test public deletes folders#2130

Merged
ScharfViktor merged 3 commits intomainfrom
e2e-fix/public-deletes-files
Mar 12, 2026
Merged

[with-tracing] fix: e2e-test public deletes folders#2130
ScharfViktor merged 3 commits intomainfrom
e2e-fix/public-deletes-files

Conversation

@ScharfViktor
Copy link
Contributor

https://ci.opencloud.rocks/repos/6/pipeline/2933/122

Scenario: public link (attempt 1, retried) # tests/e2e/cucumber/features/shares/link.feature:9
   ......
   ✔ And "Anonymous" creates the following resources # tests/e2e/cucumber/steps/ui/resources.ts:8
       | resource       | type   |
       | myfolder       | folder |
       | myfolder/child | folder |
   ✔ And "Anonymous" uploads the following resources in public link page # tests/e2e/cucumber/steps/ui/public.ts:91
       | resource | type   |
       | PARENT   | folder |
   ✔ And "Anonymous" moves the following resource using drag-drop # tests/e2e/cucumber/steps/ui/resources.ts:99
       | resource      | to        |
       | new-lorem.txt | SubFolder |
   ✔ And "Anonymous" copies the following resource using sidebar-panel # tests/e2e/cucumber/steps/ui/resources.ts:99
       | resource  | to       |
       | lorem.txt | myfolder |
   ✔ And "Anonymous" renames the following public link resources # tests/e2e/cucumber/steps/ui/public.ts:84
       | resource     | as               |
       | lorem.txt    | lorem_new.txt    |
       | textfile.txt | textfile_new.txt |
   ✖ And "Anonymous" deletes the following resources from public link using batch action # tests/e2e/cucumber/steps/ui/public.ts:109
       | resource  | from     |
       | lorem.txt | myfolder |
       | child     | myfolder |
       locator.waitFor: Timeout 30000ms exceeded.
       Call log:
         - waiting for locator('//*[@data-test-selection-resource-name="child"]//input[@type="checkbox"]') to be visible
       
           at selectOrDeselectResources (/woodpecker/src/github.com/opencloud-eu/web/web/tests/e2e/support/objects/app-files/resource/actions.ts:606:66)
           at async Module.deleteResource (/woodpecker/src/github.com/opencloud-eu/web/web/tests/e2e/support/objects/app-files/resource/actions.ts:868:13)
           at async Public.delete (/woodpecker/src/github.com/opencloud-eu/web/web/tests/e2e/support/objects/app-files/page/public.ts:54:9)
           at async processDelete (/woodpecker/src/github.com/opencloud-eu/web/web/tests/e2e/cucumber/steps/ui/resources.ts:305:9)
           at async World.<anonymous> (/woodpecker/src/github.com/opencloud-eu/web/web/tests/e2e/cucumber/steps/ui/public.ts:112:5)

fail is due this step:

And "Anonymous" creates the following resources # tests/e2e/cucumber/steps/ui/resources.ts:8
       | resource       | type   |
       | myfolder       | folder |
       | myfolder/child | folder |

The test should have failed at this step because we were unable to create the child folder -> no MKCOL request on the network. I think the problem may be in the parent folder myfolder-> it is displayed in the interface, but we have not verified that MKCOL has been completed.

Screenshot 2026-03-12 at 09 30 40

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Mar 12, 2026

now test fails in right place

Screenshot 2026-03-12 at 11 50 32

I see that test clicks by create btn but web doesn't send MKCOL request - so child folder is not being created.

I added extra checking that button create is available and change promise according https://playwright.dev/docs/api/class-page#page-wait-for-request

I hope this helps.

@ScharfViktor
Copy link
Contributor Author

I see that test clicks by create btn but web doesn't send MKCOL request - so child folder is not being created.

it stills fail in CI. localy works fine
@AlexAndBear any ideas why it happens?

@ScharfViktor
Copy link
Contributor Author

I see that test clicks by create btn but web doesn't send MKCOL request - so child folder is not being created.

it stills fail in CI. localy works fine @AlexAndBear any ideas why it happens?

no, look step before:

image
And "Anonymous" creates the following resources # tests/e2e/cucumber/steps/ui/resources.ts:8
       | resource       | type   |
       | myfolder       | folder |
       | myfolder/child | folder |

Anonymous can create myfolder(send mkcol request) but can't create subfolder child(doesn't send mkcol). In both steps I check that create is enabled.

@ScharfViktor
Copy link
Contributor Author

I found, when test opens myfolder -> new button is disabled and propfind didn't get 207.
test tries to create a subfolder when the parent folder has not been fully loaded.

@ScharfViktor ScharfViktor force-pushed the e2e-fix/public-deletes-files branch from 600f8d4 to 8c062d4 Compare March 12, 2026 13:02
@ScharfViktor ScharfViktor changed the title fix: e2e-test public deletes folders [with-tracing] fix: e2e-test public deletes folders Mar 12, 2026
@ScharfViktor
Copy link
Contributor Author

@AlexAndBear It looks good now 😅 Please review it.

Copy link
Member

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

@ScharfViktor ScharfViktor merged commit e0c8112 into main Mar 12, 2026
28 checks passed
@ScharfViktor ScharfViktor deleted the e2e-fix/public-deletes-files branch March 12, 2026 16:37
@openclouders openclouders mentioned this pull request Mar 12, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants