Skip to content

feat: add to favorites in preview app#2251

Merged
AlexAndBear merged 3 commits intomainfrom
preview-app-add-favorites-action
Mar 30, 2026
Merged

feat: add to favorites in preview app#2251
AlexAndBear merged 3 commits intomainfrom
preview-app-add-favorites-action

Conversation

@AlexAndBear
Copy link
Copy Markdown
Member

@AlexAndBear AlexAndBear commented Mar 28, 2026

Description

image

Related Issue

  • Fixes

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
Copy link
Copy Markdown
Member Author

Wait until #2255 is merged and adjust the tooltip

Copy link
Copy Markdown
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I like it a lot. The tooltip is confusing though, could you look into re-using the action label?

@AlexAndBear AlexAndBear force-pushed the preview-app-add-favorites-action branch from 9334af3 to 1ddd756 Compare March 30, 2026 10:03
@AlexAndBear AlexAndBear requested a review from kulmann March 30, 2026 10:04
Copy link
Copy Markdown
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@AlexAndBear AlexAndBear merged commit 50005f5 into main Mar 30, 2026
29 checks passed
@AlexAndBear AlexAndBear deleted the preview-app-add-favorites-action branch March 30, 2026 10:29
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenCloud Team Board Mar 30, 2026
@openclouders openclouders mentioned this pull request Mar 30, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants