Fix a batch of minor issues#2263
Closed
pascalwengerter wants to merge 3 commits intoopencloud-eu:mainfrom
Closed
Conversation
JammingBen
requested changes
Mar 31, 2026
| expect(addShare).toHaveBeenCalled() | ||
| }) | ||
| it('passes the expiration date set via collaboratorExpiryChanged to addShare', async () => { | ||
| const { wrapper } = getWrapper({}, { OcDrop: { template: '<div />', methods: { hide: vi.fn() } } }) |
Member
There was a problem hiding this comment.
The web-test-helpers package exports a ocDropStub for this exact use case, I guess it should work here.
| } | ||
|
|
||
| drop?.show({ event, useMouseAnchor: true }) | ||
| drop?.show({ event, useMouseAnchor: true, noFocus: true }) |
Member
There was a problem hiding this comment.
We need the focus for a11y reasons. The user should be able to navigate the drop menu with arrow keys, which breaks then setting noFocus: true here.
Contributor
Author
|
Closing this in favor of dedicated PRs for the individual issues. Not sure how to resolve #2244 without causing a11y regressions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
accesssTokenwith Triple S" #2262Fixes Sharing: expiration date does not get applied #2235