feat: handle UI_InsertFile postMessage from Collabora#2270
Open
pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
Open
feat: handle UI_InsertFile postMessage from Collabora#2270pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
Add handler for Collabora's UI_InsertFile postMessage, which is sent when EnableInsertRemoteFile is true. Opens the OpenCloud file picker filtered by MIME types from the message, then sends back the selected file's download URL via the callback specified by Collabora (Action_CompareDocuments). Note: line 364, added the return after the UI_InsertGraphic handler for consistency with the other handlers. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Author
|
server-side: opencloud-eu/opencloud#2555 |
JammingBen
reviewed
Apr 2, 2026
Member
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
Code LGTM and works just fine, thanks!
Though I had to bump the Collabora version in our dev setup to v25.04.9.4.1 to make it work. I guess this feature is not available in older versions? If so, do you mind bumping the Collabora version in our docker-compose.yml file also with this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add handler for Collabora's UI_InsertFile postMessage, which is sent
when EnableInsertRemoteFile is true. Opens the OpenCloud file picker
filtered by MIME types from the message, then sends back the selected
file's download URL via the callback specified by
Collabora (Action_CompareDocuments).
Note: line 364, added the return after the UI_InsertGraphic handler for
consistency with the other handlers.
Signed-off-by: Pedro Pinto Silva pedro.silva@collabora.com