Skip to content

feat: redesign share sidebar panel#2293

Merged
AlexAndBear merged 7 commits intomainfrom
issues/2078
Apr 7, 2026
Merged

feat: redesign share sidebar panel#2293
AlexAndBear merged 7 commits intomainfrom
issues/2078

Conversation

@AlexAndBear
Copy link
Copy Markdown
Member

Description

image

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copy link
Copy Markdown
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing a few small things:

  • The horizontal padding to the sides feels a bit too big. I think it should be 16px in total, just like the files details root panel. It seems to be 24px for the shares.
  • The 3-dots-menu next to the "Share" button is missing a hover.
  • The "Search" placeholder inside the invite input is jumping on focus.
  • The role select ("Can view") beneath the invite input and the "Add link" button now have a visible hover, maybe set no-hover? Because it looks a bit off without any margin.
  • Something happened to the paddings of the link and people share menus, they're too big, especially top:
Image

Comment thread packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Outdated
Comment thread packages/web-app-files/src/components/SideBar/Shares/FileShares.vue Outdated
@AlexAndBear AlexAndBear requested a review from JammingBen April 7, 2026 10:27
AlexAndBear and others added 6 commits April 7, 2026 13:44
….vue

Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
…s.vue

Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
@AlexAndBear AlexAndBear merged commit 32a3ddc into main Apr 7, 2026
29 checks passed
@AlexAndBear AlexAndBear deleted the issues/2078 branch April 7, 2026 21:45
openclouders pushed a commit that referenced this pull request Apr 7, 2026
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
@openclouders openclouders mentioned this pull request Apr 7, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign share sidebar panel

2 participants