Skip to content

feat: set global color-scheme #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JammingBen merged 1 commit into from
Apr 16, 2026
Merged

feat: set global color-scheme #2379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<head>
<meta charset="utf-8" />
<meta name="viewport" content="initial-scale=1.0, minimum-scale=1.0" />
<meta name="theme-color" content="#375f7E" />
Copy link
Copy Markdown
Member

@kulmann kulmann Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the removal? I thought this does something shiny in Safari

Copy link
Copy Markdown
Member Author

@JammingBen JammingBen Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, can you remember what? 🤔 I thought I remove it because it's not widely supported by browsers and #375f7e looks like a random color that's not related to any of our colors.

Copy link
Copy Markdown
Member

@kulmann kulmann Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍 no idea where it's even visible in Safari. Ok, kill it then.

<meta http-equiv="x-ua-compatible" content="IE=edge" />

<title>__TITLE__</title>
Expand Down
8 changes: 0 additions & 8 deletions packages/design-system/src/components/OcDatepicker/OcDatepicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,5 @@ watch(
.oc-date-picker input::-webkit-calendar-picker-indicator {
@apply cursor-pointer;
}

.oc-date-picker-dark input {
color-scheme: dark;
}

.oc-date-picker-dark input::-webkit-calendar-picker-indicator {
filter: invert(0);
}
}
</style>
1 change: 1 addition & 0 deletions packages/web-pkg/src/composables/piniaStores/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ export const useThemeStore = defineStore('theme', () => {
currentLocalStorageThemeName.value = unref(currentTheme).label
}

document.documentElement.style.colorScheme = theme.isDark ? 'dark' : 'light'
const customizableDesignTokens = [
{ name: 'roles', prefix: 'role' },
{ name: 'colorPalette', prefix: 'color' }
Expand Down