Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a couple of UI icons (app switcher + Files “Tiles view”) and adds the required design-system SVG assets to support the new icon name.
Changes:
- Swap the topbar application switcher icon from
appstoapps-3. - Update the Files “Tiles view” icon to
gallery-view-2and setfillType: 'none'to match the unsuffixed SVG asset. - Add
apps-3SVG assets (-filland-line) to the design-system icon set.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue | Switches the app switcher button icon to apps-3. |
| packages/web-app-files/src/composables/extensions/useFolderViews.ts | Updates the “Tiles view” icon to gallery-view-2 and uses fillType: 'none'. |
| packages/design-system/src/assets/icons/apps-3-line.svg | Adds the apps-3 line-variant icon asset. |
| packages/design-system/src/assets/icons/apps-3-fill.svg | Adds the apps-3 fill-variant icon asset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
as a good sniper-pm I added the request
other than that: perfect! thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes