Skip to content

feat: show mobile sidebar and FAB on tablets in portrait mode#2433

Merged
AlexAndBear merged 6 commits intomainfrom
sidebar-tablet-portrait-mode
Apr 23, 2026
Merged

feat: show mobile sidebar and FAB on tablets in portrait mode#2433
AlexAndBear merged 6 commits intomainfrom
sidebar-tablet-portrait-mode

Conversation

@AlexAndBear
Copy link
Copy Markdown
Member

Description

Related Issue

  • Fixes <issue_link>

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@kulmann
Copy link
Copy Markdown
Member

kulmann commented Apr 23, 2026

What do you think about setting a max-width on the mobile sidebar? Our desktop resolution sidebar has a width of 230px. I find that rather narrow on mobile (see screenshots). Something like 320px feels more natural. I like that better than going 85% width regardless of the viewport size. Last screenshot is showing 85% on a tablet width.

Screenshot 2026-04-23 at 07 48 01 Screenshot 2026-04-23 at 07 48 41 Screenshot 2026-04-23 at 07 49 53 Screenshot 2026-04-23 at 07 44 06

Comment thread packages/design-system/src/composables/useIsMobile/index.ts Outdated
Comment thread packages/design-system/src/composables/useIsMobile/index.ts
@AlexAndBear
Copy link
Copy Markdown
Member Author

What do you think about setting a max-width on the mobile sidebar? Our desktop resolution sidebar has a width of 230px. I find that rather narrow on mobile (see screenshots). Something like 320px feels more natural. I like that better than going 85% width regardless of the viewport size. Last screenshot is showing 85% on a tablet width.

Screenshot 2026-04-23 at 07 48 01 Screenshot 2026-04-23 at 07 48 41 Screenshot 2026-04-23 at 07 49 53 Screenshot 2026-04-23 at 07 44 06

I chose a more balanced way:

on mobile (smartphone) 85%, on tablet sizes 320px as it feels more natural that way

@AlexAndBear AlexAndBear requested a review from JammingBen April 23, 2026 07:24
@AlexAndBear AlexAndBear merged commit 841fb73 into main Apr 23, 2026
29 checks passed
@AlexAndBear AlexAndBear deleted the sidebar-tablet-portrait-mode branch April 23, 2026 10:17
@openclouders openclouders mentioned this pull request Apr 23, 2026
1 task
@AlexAndBear AlexAndBear self-assigned this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants