Tiles view, replace sort select with less visual obstrutive filter-chip#245
Merged
AlexAndBear merged 1 commit intomainfrom Feb 27, 2025
Merged
Tiles view, replace sort select with less visual obstrutive filter-chip#245AlexAndBear merged 1 commit intomainfrom
AlexAndBear merged 1 commit intomainfrom
Conversation
Member
Author
AlexAndBear
force-pushed
the
issues/214-2
branch
from
21b520a to
456489f
Compare
AlexAndBear
commented
Feb 26, 2025
| </svg></button><svg xmlns="http://www.w3.org/2000/svg" width="14" height="10" role="presentation" class="vs__open-indicator"> | ||
| <path d="M9.211364 7.59931l4.48338-4.867229c.407008-.441854.407008-1.158247 0-1.60046l-.73712-.80023c-.407008-.441854-1.066904-.441854-1.474243 0L7 5.198617 2.51662.33139c-.407008-.441853-1.066904-.441853-1.474243 0l-.737121.80023c-.407008.441854-.407008 1.158248 0 1.600461l4.48338 4.867228L7 10l2.211364-2.40069z"></path> | ||
| </svg> | ||
| </svg></button><span class="oc-icon oc-icon-s oc-icon-passive"><!----></span> |
Member
Author
There was a problem hiding this comment.
From my other pr, missed to update snapshots, result is correct
Member
Author
|
Toby said yes, r2r :) |
Member
|
nice, thank you! |
JammingBen
approved these changes
Feb 27, 2025
Member
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
LGTM. While you're at it, maybe you can check why sorting by anything other than name or date crashes on the Space overview? Happens on main as well though.
Member
Author
Already saw that 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes