Skip to content

feat: create new contacts#2458

Merged
tammi-23 merged 3 commits intomainfrom
issue/2010
May 6, 2026
Merged

feat: create new contacts#2458
tammi-23 merged 3 commits intomainfrom
issue/2010

Conversation

@tammi-23
Copy link
Copy Markdown
Contributor

IMplemets #2010

Comment thread packages/web-app-contacts/src/components/ContactCreateEditor.vue Outdated
Copy link
Copy Markdown
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small things I'm noticing in the UI:

  • The modal has the "Create"-button on the left side and a divider line at the top. Shouldn't this match the appearance of other modals (button on the right, no divider line)?
  • The bottom drawer looks like it's missing a bit of padding to the sides.

Comment thread packages/web-app-contacts/src/components/ContactCreateEditor.vue Outdated
Comment thread packages/web-app-contacts/src/components/ContactCreateEditor.vue Outdated
Comment thread packages/web-app-contacts/src/composables/useContactEditor.ts Outdated
Comment thread packages/web-app-contacts/src/composables/useCreateContact.ts
Comment thread packages/web-app-contacts/src/components/ContactCreateForm.vue
@JammingBen JammingBen changed the title Issue/2010 feat: create new contacts May 5, 2026
Copy link
Copy Markdown
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nitpick from my side, the vertical padding of the headline in the bottom drawer is too big, I think it should match the other bottom drawers:

Image

Copy link
Copy Markdown
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tammi-23 tammi-23 dismissed AlexAndBear’s stale review May 6, 2026 13:28

Requested change has been implemented in the latest commits.

@tammi-23 tammi-23 merged commit 2d1fe9a into main May 6, 2026
29 checks passed
@tammi-23 tammi-23 deleted the issue/2010 branch May 6, 2026 13:53
@openclouders openclouders mentioned this pull request May 6, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants