Optimize sidebar behaviour on mobile devices#251
Merged
JammingBen merged 2 commits intomainfrom Feb 28, 2025
Merged
Conversation
Reworks how the sidebars on the left and right behave on smaller screens to improve the mobile experience. The left sidebar now toggles automatically with smaller screen sizes. The right sidebar on the other hand only snaps on screens <580px. Also fixes the search bar appearance in the mobile view.
JammingBen
force-pushed
the
feat/mobile-sidebars
branch
from
ea4e6d7 to
983c667
Compare
AlexAndBear
approved these changes
Feb 28, 2025
Member
AlexAndBear
left a comment
AlexAndBear
left a comment
There was a problem hiding this comment.
Damn, love it 😍
There is still a little bug, that the main content disappears when the sidebar is opened in mobile view and the viewport will be extended. This also occurs on the main branch.
Member
Author
Yes, will tackle that in a separate PR 👍 |
JammingBen
added a commit
that referenced
this pull request
Mar 12, 2025
Follow-up after #251 where we changed the snapping point of the right sidebar.
kulmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks how the sidebars on the left and right behave on smaller screens to improve the mobile experience. The left sidebar now toggles automatically with smaller screen sizes. The right sidebar on the other hand only snaps on screens <580px.
As discussed with @tbsbdr , we currently don't care about the user setting for the left sidebar. That means resizing the screen could potentially expand the sidebar despite the user having it toggled in general. We can tackle this as soon as we correctly persist this setting.
Also fixes the search bar appearance in the mobile view and refactors 2 components to use script setup. So this PR is best reviewed by commits.
closes #212