fix(editor): json rendering, plaintext serialization#2573
Merged
Conversation
The text editor is not supposed to render tiptap json from any json file. This would mean that the editor doesn't display json files properly. The functionality for rendering tiptap json (= richtext format) is reserved for dedicated apps like the notes app.
JammingBen
changed the title
Prevent the duplicated blank lines when saving and reloading plaintext files.
tammi-23
approved these changes
May 22, 2026
Contributor
tammi-23
left a comment
tammi-23
left a comment
There was a problem hiding this comment.
All 3 issues are fixed 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few issues with the editor:
The text editor is not supposed to render tiptap json from any json file. This would mean that the editor doesn't display json files properly. The functionality for rendering tiptap json (= richtext format) is reserved for dedicated apps like the notes app.
Fix error when saving and closing plaintext files.
Prevent the duplicated blank lines when saving and reloading plaintext files.