Skip to content

fix(design-system): add id to OcSearchBar #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JammingBen merged 2 commits into from
May 22, 2026
+7 −1
Merged

fix(design-system): add id to OcSearchBar #2587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6e826f
fix(design-system): add id to OcSearchBar
JammingBen May 22, 2026
2f8af37
test: add unit test for searchbar id
JammingBen May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/design-system/src/components/OcSearchBar/OcSearchBar.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ describe('OcSearchBar', () => {
searchButtonWrapper: '.oc-search-button-wrapper',
searchClearButton: '.oc-search-clear'
}
it('should have an id', () => {
const wrapper = getWrapper()
expect(wrapper.find('input').attributes('id')).toBeDefined()
})
describe('search grid role', () => {
it('should be undefined if filter is enabled', () => {
const wrapper = getWrapper({ isFilter: true })
Expand Down
4 changes: 3 additions & 1 deletion packages/design-system/src/components/OcSearchBar/OcSearchBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
>
<div class="flex-1 relative">
<input
:id="inputId"
v-model="model"
:class="inputClass"
:aria-label="label"
Expand Down Expand Up @@ -56,7 +57,7 @@
</template>

<script lang="ts" setup>
import { computed, unref, watch } from 'vue'
import { computed, unref, useId, watch } from 'vue'
import { useGettext } from 'vue3-gettext'
import OcButton, { Props as OcButtonProps } from '../OcButton/OcButton.vue'
import OcIcon from '../OcIcon/OcIcon.vue'
Expand Down Expand Up @@ -190,6 +191,7 @@ defineSlots<Slots>()

const { $gettext } = useGettext()

const inputId = `search-input-${useId()}`
const inputClass = computed(() => {
const classes = [
'oc-search-input',
Expand Down