Skip to content

feat: use embed mode for copy and move actions#2599

Merged
AlexAndBear merged 8 commits into
mainfrom
copy-move-embed-file-picker
May 28, 2026
Merged

feat: use embed mode for copy and move actions#2599
AlexAndBear merged 8 commits into
mainfrom
copy-move-embed-file-picker

Conversation

@AlexAndBear
Copy link
Copy Markdown
Member

@AlexAndBear AlexAndBear commented May 27, 2026 •
edited
Loading

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear added the Type:Maintenance E.g. technical debt, packaging, etc. label May 27, 2026
@AlexAndBear AlexAndBear force-pushed the copy-move-embed-file-picker branch from 355d8b9 to 80e6e67 Compare May 27, 2026 19:53
@AlexAndBear
Copy link
Copy Markdown
Member Author

AlexAndBear commented May 27, 2026 •
edited
Loading

When we create a space from within the embed mode and want to copy move a file to this space, the actions fails.
This is because we actually don't have the space is the store. We need sse events for spaces to get this working:

opencloud-eu/opencloud#2844

@AlexAndBear AlexAndBear force-pushed the copy-move-embed-file-picker branch from 8ebb27d to 27a128c Compare May 28, 2026 12:09
JammingBen
JammingBen reviewed May 28, 2026
View reviewed changes
Comment thread packages/web-runtime/src/container/sse/spaces.ts Outdated
Comment thread packages/web-app-files/src/composables/actions/files/useFileActionsCopy.ts Outdated
Comment thread packages/web-app-files/src/composables/actions/files/useFileActionsMove.ts Outdated
Comment thread packages/web-app-files/src/composables/actions/files/useFileActionsCopy.ts Outdated
Comment thread packages/web-app-files/src/composables/actions/files/useFileActionsMove.ts Outdated
Comment thread packages/web-pkg/src/components/Modals/LocationPickerModal.vue Outdated
@AlexAndBear AlexAndBear requested a review from JammingBen May 28, 2026 13:52
@AlexAndBear AlexAndBear added Type:Enhancement and removed Type:Maintenance E.g. technical debt, packaging, etc. labels May 28, 2026
@AlexAndBear AlexAndBear changed the title refactor: use embed mode for copy and move actions feat: use embed mode for copy and move actions May 28, 2026
@AlexAndBear AlexAndBear marked this pull request as ready for review May 28, 2026 14:01
JammingBen
JammingBen approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexAndBear AlexAndBear merged commit 1ea00e8 into main May 28, 2026
29 checks passed
@AlexAndBear AlexAndBear deleted the copy-move-embed-file-picker branch May 28, 2026 14:45
@openclouders openclouders mentioned this pull request May 28, 2026
Open
1 task
@ScharfViktor ScharfViktor mentioned this pull request May 29, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees

No one assigned

Labels

Type:Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexAndBear @JammingBen @ScharfViktor