You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
when we run tests parallel RETRY=1 HEADLESS=true PARALLEL=4 ./run-e2e.sh --suites admin-settings test was flaky because admin user had 2 similar team A spaces. fixed it
This might fix it for now, but is really hard to maintain as the test writer has to be careful what user/groups/spaces to use.
In theory every test should be independent of all the others, but if we run tests in parallel on the same system that is a big issue.
That generally means we need to be careful not to re-use the same space ids across multiple tests?
No, now we create for each test Alice_uniqueNameBrian_uniqueName. when these unique users create a space with the same name - there are no conflicts. But only one non-unique user is the admin. There was one fake here, when admin created the same space in parallel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when we run tests parallel
RETRY=1 HEADLESS=true PARALLEL=4 ./run-e2e.sh --suites admin-settingstest was flaky because admin user had 2 similarteam Aspaces. fixed it