Skip to content

Fix test when admin creates spaces in parallel#281

Merged
ScharfViktor merged 1 commit intomainfrom
fixParallelTestWithCreatingSameSpace
Mar 6, 2025
Merged

Fix test when admin creates spaces in parallel#281
ScharfViktor merged 1 commit intomainfrom
fixParallelTestWithCreatingSameSpace

Conversation

@ScharfViktor
Copy link
Copy Markdown
Contributor

@ScharfViktor ScharfViktor commented Mar 5, 2025

when we run tests parallel RETRY=1 HEADLESS=true PARALLEL=4 ./run-e2e.sh --suites admin-settings test was flaky because admin user had 2 similar team A spaces. fixed it

@ScharfViktor ScharfViktor requested review from a team and JammingBen and removed request for a team March 5, 2025 14:39
Copy link
Copy Markdown
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

That generally means we need to be careful not to re-use the same space ids across multiple tests?

@individual-it
Copy link
Copy Markdown
Contributor

This might fix it for now, but is really hard to maintain as the test writer has to be careful what user/groups/spaces to use.
In theory every test should be independent of all the others, but if we run tests in parallel on the same system that is a big issue.

@ScharfViktor
Copy link
Copy Markdown
Contributor Author

That generally means we need to be careful not to re-use the same space ids across multiple tests?

No, now we create for each test Alice_uniqueName Brian_uniqueName. when these unique users create a space with the same name - there are no conflicts. But only one non-unique user is the admin. There was one fake here, when admin created the same space in parallel.

@ScharfViktor ScharfViktor merged commit a6d7ebf into main Mar 6, 2025
@ScharfViktor ScharfViktor deleted the fixParallelTestWithCreatingSameSpace branch March 6, 2025 07:40
@kulmann kulmann changed the title fix test when admin creates spaces parallel Fix test when admin creates spaces parallel Mar 17, 2025
@kulmann kulmann changed the title Fix test when admin creates spaces parallel Fix test when admin creates spaces in parallel Mar 17, 2025
@openclouders openclouders mentioned this pull request Mar 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants