Don't show password while using generate password method#300
Merged
AlexAndBear merged 1 commit intomainfrom Mar 10, 2025
Merged
Don't show password while using generate password method#300AlexAndBear merged 1 commit intomainfrom
AlexAndBear merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR hides the generated password by removing the line that makes it visible after generation.
- Removed "showPassword.value = true" to prevent displaying the generated password
- Continues to emit the generated password event
Reviewed Changes
| File | Description |
|---|---|
| packages/design-system/src/components/OcTextInputPassword/OcTextInputPassword.vue | Removed code that was showing the generated password, aligning with the PR objective to keep the password hidden |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes