Fix mark highlight does not work while searching users#309
Merged
JammingBen merged 4 commits intomainfrom Mar 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with mark highlighting not working during user searches by integrating a table reference and updating related dependencies and classes.
- Introduces a tableRef using useTemplateRef to bind the OcTable component.
- Updates the watch dependency array to include tableRef, ensuring re-marking occurs as needed.
- Adds tdClass attributes to table columns for proper element targeting by mark.js.
Comments suppressed due to low confidence (1)
packages/web-app-admin-settings/src/components/Users/UsersList.vue:343
- Including tableRef in the watch dependency array may trigger extraneous re-runs of the marking logic. Please review if this dependency is required or consider refining the dependency list to avoid unintended behavior.
watch([displayNameQuery, paginatedItems, tableRef], async() => {
JammingBen
requested changes
Mar 12, 2025
….vue Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
JammingBen
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes