Skip to content

Fix mark highlight does not work while searching users#309

Merged
JammingBen merged 4 commits intomainfrom
mark-doesn-not-work-while-searching-users
Mar 12, 2025
Merged

Fix mark highlight does not work while searching users#309
JammingBen merged 4 commits intomainfrom
mark-doesn-not-work-while-searching-users

Conversation

@AlexAndBear
Copy link
Copy Markdown
Member

Description

Related Issue

  • Fixes <issue_link>

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • New feature (an additional functionality that doesn't break existing code)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copilot AI review requested due to automatic review settings March 12, 2025 08:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with mark highlighting not working during user searches by integrating a table reference and updating related dependencies and classes.

  • Introduces a tableRef using useTemplateRef to bind the OcTable component.
  • Updates the watch dependency array to include tableRef, ensuring re-marking occurs as needed.
  • Adds tdClass attributes to table columns for proper element targeting by mark.js.
Comments suppressed due to low confidence (1)

packages/web-app-admin-settings/src/components/Users/UsersList.vue:343

  • Including tableRef in the watch dependency array may trigger extraneous re-runs of the marking logic. Please review if this dependency is required or consider refining the dependency list to avoid unintended behavior.
watch([displayNameQuery, paginatedItems, tableRef], async() => {

@AlexAndBear AlexAndBear requested a review from JammingBen March 12, 2025 08:18
Comment thread packages/web-app-admin-settings/src/components/Users/UsersList.vue Outdated
….vue

Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
@JammingBen JammingBen merged commit 42afe32 into main Mar 12, 2025
@JammingBen JammingBen deleted the mark-doesn-not-work-while-searching-users branch March 12, 2025 08:57
@kulmann kulmann changed the title Fix: mark hilight does not work while searching users Fix mark hilight does not work while searching users Mar 17, 2025
@kulmann kulmann changed the title Fix mark hilight does not work while searching users Fix mark highlight does not work while searching users Mar 17, 2025
@openclouders openclouders mentioned this pull request Mar 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants