Skip to content

Minor style fixes#326

Merged
kulmann merged 4 commits intomainfrom
style-fixes
Mar 14, 2025
Merged

Minor style fixes#326
kulmann merged 4 commits intomainfrom
style-fixes

Conversation

@kulmann
Copy link
Copy Markdown
Member

@kulmann kulmann commented Mar 14, 2025

Description

Same style fixes, namely:

  1. Resource tile background was surface instead of surface-container when built trough pnpm build (was ok when built through pnpm vite).
  2. Text editor long URLs were not collapsed in a production build (css class names for the selector are different in pnpm build and pnpm vite)
  3. hover color on AppTopBar action buttons

Types of changes

  • Bugfix
  • New feature (an additional functionality that doesn't break existing code)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copilot AI review requested due to automatic review settings March 14, 2025 14:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements style fixes to address inconsistencies between production and development builds.

  • Adjusts CSS rules in the TextEditor for collapsing long URLs.
  • Updates the ResourceTile component by removing an extra class and enforcing specific background colors.
  • Adds a hover style for AppTopBar action buttons.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
packages/web-pkg/src/components/TextEditor/TextEditor.vue Updates CSS selector to adjust long URL collapsing in production builds
packages/web-pkg/src/components/FilesList/ResourceTile.vue Removes the oc-rounded class and adds !important to background colors for consistency
packages/web-pkg/src/components/AppTopBar.vue Introduces hover styles for action buttons to improve visual feedback
Comments suppressed due to low confidence (2)

packages/web-pkg/src/components/TextEditor/TextEditor.vue:167

  • [nitpick] Verify that the selector '.cm-line:has(.ͼy)' correctly targets the intended elements; if these generated class names might change between builds, consider a more robust approach.
.cm-line:has(.ͼy),

packages/web-pkg/src/components/FilesList/ResourceTile.vue:297

  • [nitpick] The use of !important may interfere with other style rules; consider refactoring the CSS to avoid its use by improving the specificity of the selectors.
background-color: var(--oc-role-secondary-container) !important;

<style lang="scss">
.oc-tile-card {
background-color: var(--oc-role-surface-container);
background-color: var(--oc-role-surface-container) !important;
Copy link

Copilot AI Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using !important here can lead to specificity issues; consider increasing the selector specificity as an alternative if possible.

Suggested change
background-color: var(--oc-role-surface-container) !important;
&.oc-tile-card {
background-color: var(--oc-role-surface-container);
}

Copilot uses AI. Check for mistakes.
@kulmann kulmann merged commit df38d31 into main Mar 14, 2025
@kulmann kulmann deleted the style-fixes branch March 14, 2025 15:14
@kulmann kulmann changed the title Style fixes Minor style fixes Mar 17, 2025
@openclouders openclouders mentioned this pull request Mar 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants