Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements style fixes to address inconsistencies between production and development builds.
- Adjusts CSS rules in the TextEditor for collapsing long URLs.
- Updates the ResourceTile component by removing an extra class and enforcing specific background colors.
- Adds a hover style for AppTopBar action buttons.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-pkg/src/components/TextEditor/TextEditor.vue | Updates CSS selector to adjust long URL collapsing in production builds |
| packages/web-pkg/src/components/FilesList/ResourceTile.vue | Removes the oc-rounded class and adds !important to background colors for consistency |
| packages/web-pkg/src/components/AppTopBar.vue | Introduces hover styles for action buttons to improve visual feedback |
Comments suppressed due to low confidence (2)
packages/web-pkg/src/components/TextEditor/TextEditor.vue:167
- [nitpick] Verify that the selector '.cm-line:has(.ͼy)' correctly targets the intended elements; if these generated class names might change between builds, consider a more robust approach.
.cm-line:has(.ͼy),
packages/web-pkg/src/components/FilesList/ResourceTile.vue:297
- [nitpick] The use of !important may interfere with other style rules; consider refactoring the CSS to avoid its use by improving the specificity of the selectors.
background-color: var(--oc-role-secondary-container) !important;
| <style lang="scss"> | ||
| .oc-tile-card { | ||
| background-color: var(--oc-role-surface-container); | ||
| background-color: var(--oc-role-surface-container) !important; |
There was a problem hiding this comment.
[nitpick] Using !important here can lead to specificity issues; consider increasing the selector specificity as an alternative if possible.
Suggested change
| background-color: var(--oc-role-surface-container) !important; | |
| &.oc-tile-card { | |
| background-color: var(--oc-role-surface-container); | |
| } |
AlexAndBear
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same style fixes, namely:
surfaceinstead ofsurface-containerwhen built troughpnpm build(was ok when built throughpnpm vite).pnpm buildandpnpm vite)Types of changes