Fix: Vue warnings#34
Merged
Merged
Conversation
This fixes a warning because an `Authorization` header can't be wildcarded (see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Headers#sect). This only affects our dev docker setup.
Exported members of the `setup()` function should not lead with any special character because those are reserved for Vue internal stuff. That also means that pinia stores must not be spread directly into a `setup()` return because they have such variable names.
Passing extraneous props to multi root components should be prevented because they get lost anyways.
Artificial route params should not be included in a `router.push()` because they will be discarded anyways (see https://github.com/vuejs/router/blob/main/packages/router/CHANGELOG.md#414-2022-08-22). So I guess this code never really worked in the recent past.
The `LoadingSpinner` component should be a reactive object due to performance reasons, hence marking it as raw (=non-reactive).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for details and explanations on the changes. None of them should have any impact on functionality.